Add support for a coordinate channel input#19
Open
pattonw wants to merge 2 commits intoaschampion:masterfrom
Open
Add support for a coordinate channel input#19pattonw wants to merge 2 commits intoaschampion:masterfrom
pattonw wants to merge 2 commits intoaschampion:masterfrom
Conversation
aschampion
reviewed
Feb 21, 2019
Owner
aschampion
left a comment
aschampion
left a comment
There was a problem hiding this comment.
Since this could be another breaking dependency for, e.g., Keras upgrades and we don't yet have evidence of practical benefit, I'm going to leave this unmerged but open for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't done any tests to determine whether the coordinate channel is useful, but if you want it here is an implementation.