Open
Conversation
breadadams
reviewed
Sep 17, 2025
augustobmoura
requested changes
Feb 24, 2026
Member
augustobmoura
left a comment
augustobmoura
left a comment
There was a problem hiding this comment.
Sorry for the delay, got tangled in a few personnal problems
| source "$(dirname "$0")/../lib/utils.sh" | ||
|
|
||
| resolve_version "$(cat "$1")" | ||
| resolve_version "$(head -n 1 "$1")" |
Member
There was a problem hiding this comment.
Can we make sure this only apply to .nvmrc? It shouldn't apply for other legacy version files (.node-version for now)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#397
As described here, the
.nvmrcfile's first line is the one that contains the version number required. This PR replaces the command to read the whole file into the version parser with a command to read just the first line.