Merged
Conversation
…ode instead of beamswath now
Angular 18 to 20
…Discovery-SearchUI into topic-seasat-migration
…e for file suffix parsing
…ion into single method
SEASAT 1 Migration
NISAR Collection -> Citation links
* Address UI Issues - Tyler
This should address UI issues raised by Tyler
- Search button arrow turns black on hover
- When in the download queue, and copying file IDs and urls the notification toast no longer shows above the download queue.
- Hyp3 on demand icons are faded in some places, specifically for product files list and baseline searches.
- Baseline search option buttons at the bottom of the details of the scene, the buttons are expanding more than they should and taking up the full width
- the seasonal search toggle seems like it lags when switching over?
* Update src/app/components/results-menu/scene-detail/scene-detail.component.scss
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update src/app/components/shared/selectors/season-selector/season-selector.component.ts
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Reversing CoPilot suggestion
* DS-6298 "Wonky" On Demand results loading
Fix Applied
Added optional chaining (?.) to all NISAR property accesses:
Files Modified:
1. src/app/components/shared/scene-metadata/scene-metadata.component.ts
- Line 107: this.scene.metadata.nisar?.frameCoverage
- Line 120: this.scene.metadata.nisar?.mainBandPolarization
- Line 126: this.scene.metadata.nisar?.sideBandPolarization
- Line 140: this.scene.metadata.nisar?.rangeBandwidth
2. src/app/components/shared/scene-metadata/scene-metadata.component.html
- Line 235: {{ scene.metadata.nisar?.frameCoverage }}
- Line 291: {{ scene.metadata.nisar?.mainBandPolarization }}
- Line 311: {{ scene.metadata.nisar?.sideBandPolarization }}
- Line 332: {{ scene.metadata.nisar?.rangeBandwidth }}
- Line 353: {{ scene.metadata.nisar?.jointObservation }}
Expected Results
- No more console errors when viewing On Demand search results
- Faster rendering of app-scenes-list component (errors were blocking render)
- Graceful handling of missing NISAR metadata for non-NISAR products
The optional chaining operator will return undefined instead of throwing an error when the nisar property doesn't exist, allowing the component to render normally.
* Fixed 'faded' HyP3 icon
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
SpicyGarlicAlbacoreRoll
added
the
minor
SpicyGarlicAlbacoreRoll
had a problem deploying
to
test-edc
GitHub Actions
Failure
SpicyGarlicAlbacoreRoll
had a problem deploying
to
test
GitHub Actions
Failure
tylercchase
approved these changes
Nov 18, 2025
SpicyGarlicAlbacoreRoll
temporarily deployed
to
test
GitHub Actions
Inactive
SpicyGarlicAlbacoreRoll
temporarily deployed
to
test-edc
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed