Reduce type duplication and make scalar aux mutable -- please review#15
Open
Buggaboo wants to merge 3 commits intoasg017:mainfrom
Open
Reduce type duplication and make scalar aux mutable -- please review#15Buggaboo wants to merge 3 commits intoasg017:mainfrom
Buggaboo wants to merge 3 commits intoasg017:mainfrom
Conversation
make callback aux mutable, because the context can change, or builder etc.
Buggaboo
changed the title
PThorpe92
added a commit
to PThorpe92/sqlite-loadable-rs
that referenced
this pull request
Jan 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please, make the scalar function callback aux mutable, because the context stored in aux can change.
In my specific flatbuffer / flexbuffer project, I have a mutable builder that creates flatbuffer and flexbuffers.