Upgrade prettier to v2 #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous glob configured in the lint:prettier task (src/**/*) did not match the implementation files directly under src/, only files 1 level down from that (in src/__tests__/). Upgraded prettier to v2 in order to take advantage of the new "prettier --write ." support (prettier/prettier#6085). Also changed to a blacklist strategy using .prettierignore rather than whitelist so that editors configured to run prettier on save only run on files we care about.
Node 8 is no longer maintained, and Prettier dropped support for Node < 10 in v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous glob configured in the
lint:prettiertask (src/**/*) did not match the implementation files directly under src/, only files 1 level down from that (in src/__tests__/), so I upgraded prettier to v2 in order to take advantage of the newprettier --write .support.yarn lint:prettier