Skip to content

fix: handle wheels without hash digests from private registries #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roundhd wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

fix: handle wheels without hash digests from private registries #793

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions uv/private/extension.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,9 +470,12 @@ def _raw_sdist_repos(_module_ctx, lock_specs, override_specs):
def _whl_repo_name(package, whl):
"""Get the repo name for a whl."""

# Use hash when available, fall back to URL-based identifier for wheels
# from private registries that don't serve PEP 503 hash fragments.
identifier = whl["hash"][len("shasum:"):][:8] if "hash" in whl else sha1(whl["url"])[:8]
return "whl__{}__{}".format(
package["name"],
whl["hash"][len("shasum:"):][:8],
identifier,
)

def _raw_whl_repos(_module_ctx, lock_specs, override_specs):
Expand All @@ -488,7 +491,10 @@ def _raw_whl_repos(_module_ctx, lock_specs, override_specs):
wheels = package.get("wheels", [])
for whl in wheels:
url = whl["url"]
shasum = whl["hash"][len("sha256:"):]

# Wheels from private registries may lack hash digests
# when the registry doesn't serve PEP 503 hash fragments.
shasum = whl["hash"][len("sha256:"):] if "hash" in whl else ""

# FIXME: Do we need to factor in the shasum or source her? Could
# have two or more sources for one "artifact".
Expand Down