fix: filter editable packages and prune dangling dependency references#794
fix: filter editable packages and prune dangling dependency references#794roundhd wants to merge 1 commit intoaspect-build:mainfrom
Conversation
Monorepo first-party packages with `source.editable` entries were not filtered by `_ignored_package`, causing downstream failures when trying to resolve wheels/sdists that don't exist. Also prune dependency references that point to removed (editable/virtual) packages to prevent resolution errors. Fixes aspect-build#791
|
Shiyuan Zheng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
|
Can you elaborate on the use-case here some? I'm not convinced deleting these dependency edges is sound, but I'm open to argument. In the reworked extension #778, the user is forced to provide a mapping from all editable/virtual firstparty packages to a Bazel target. We no longer delete them. It could be valid for a concrete package to take a dependency on a virtualized/editable vendored copy, in which case this would be incorrect. |

Summary
Monorepo first-party packages with
source.editableentries were not filtered by_ignored_package, causing downstream failures when trying to resolve wheels/sdists that don't exist.After filtering, dependency lists still reference the removed packages, causing further resolution errors.
Changes:
source.editablecheck to_ignored_packagedependenciesandoptional-dependenciesFixes #791
Related: #789