Skip to content

fix: filter editable packages and prune dangling dependency references#794

Open
roundhd wants to merge 1 commit intoaspect-build:mainfrom
roundhd:fix/editable-packages
Open

fix: filter editable packages and prune dangling dependency references#794
roundhd wants to merge 1 commit intoaspect-build:mainfrom
roundhd:fix/editable-packages

Conversation

@roundhd
Copy link

@roundhd roundhd commented Feb 12, 2026

Summary

Monorepo first-party packages with source.editable entries were not filtered by _ignored_package, causing downstream failures when trying to resolve wheels/sdists that don't exist.

After filtering, dependency lists still reference the removed packages, causing further resolution errors.

Changes:

  • Add source.editable check to _ignored_package
  • After filtering ignored packages, prune dangling references from dependencies and optional-dependencies

Fixes #791
Related: #789

Monorepo first-party packages with `source.editable` entries were not
filtered by `_ignored_package`, causing downstream failures when trying
to resolve wheels/sdists that don't exist.

Also prune dependency references that point to removed (editable/virtual)
packages to prevent resolution errors.

Fixes aspect-build#791
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Shiyuan Zheng seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aspect-workflows
Copy link

aspect-workflows bot commented Feb 12, 2026

Bazel 8 (Test)

All tests were cache hits

31 tests (100.0%) were fully cached saving 48s.


Bazel 9 (Test)

All tests were cache hits

31 tests (100.0%) were fully cached saving 1m 10s.


Bazel 8 (Test)

e2e

All tests were cache hits

14 tests (100.0%) were fully cached saving 12s.


Bazel 9 (Test)

e2e

All tests were cache hits

12 tests (100.0%) were fully cached saving 7s.


Bazel 8 (Test)

examples/uv_pip_compile

All tests were cache hits

1 test (100.0%) was fully cached saving 335ms.

@arrdem
Copy link
Collaborator

arrdem commented Feb 13, 2026

Can you elaborate on the use-case here some? I'm not convinced deleting these dependency edges is sound, but I'm open to argument.

In the reworked extension #778, the user is forced to provide a mapping from all editable/virtual firstparty packages to a Bazel target. We no longer delete them. It could be valid for a concrete package to take a dependency on a virtualized/editable vendored copy, in which case this would be incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: uv extension does not filter editable packages, causing dangling dependency references

3 participants

Comments