fix(uv): invalidate extension state when lock/annotation files change#798
Closed
mkanat wants to merge 1 commit intoaspect-build:mainfrom
Closed
fix(uv): invalidate extension state when lock/annotation files change#798mkanat wants to merge 1 commit intoaspect-build:mainfrom
mkanat wants to merge 1 commit intoaspect-build:mainfrom
Conversation
|
Author
|
One thing I don't know about this is whether this is the right place in the codebase to do this, since I'm not intimately familiar with the codebase. |
Collaborator
Author
|
Okay, great, I'll close this! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes #797 by explicitly watching uv lock/annotation source files in the module extension so file content changes invalidate cached extension state in normal lockfile modes.
Reproduction
Reproduced from a current head checkout using a minimal bzlmod workspace that depends on published
aspect_rules_py@1.8.4:bazelisk mod deps --lockfile_mode=refreshand query an existing dep (@hub//cowsay:all).uv.lockto add a new dep (click) and rerunbazelisk mod deps --lockfile_mode=refresh.@hub//click:all.Actual on
1.8.4: missing package error (@@aspect_rules_py++uv+hub//click).Change
module_ctx.watch(lock.src)before lockfile decode.module_ctx.watch(ann.src)before annotations decode.Verification
1.8.4.@hub//click:allcorrectly under--lockfile_mode=refresh.