chore(docs): improve release flow automation scripts robustness#12
chore(docs): improve release flow automation scripts robustness#12
Conversation
Signed-off-by: assagman <ahmetsercansagman@gmail.com>
Summary of ChangesHello @assagman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the reliability of the release automation scripts by introducing robust error handling for critical steps. It ensures that the scripts can gracefully manage scenarios where expected resources, like an open release PR, are not found, and provides more intelligent waiting for GitHub Actions workflows, preventing indefinite hangs on non-successful outcomes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Code Review
This pull request improves the robustness of the release automation scripts by adding necessary checks for the existence of a release PR and by implementing more resilient waiting loops for GitHub Actions workflows. The changes are solid and correctly address potential failure points. I have a couple of suggestions to further simplify the workflow waiting logic by using the gh run watch command, which is designed for this purpose and can make the script more concise and readable.
There was a problem hiding this comment.
Pull request overview
Improves the release-flow documentation scripts to fail fast when expected artifacts (release PR, workflow runs) are missing or unsuccessful, avoiding indefinite waits.
Changes:
- Add a guard clause to error out when no open release PR is found before attempting merge.
- Replace “wait until success” loops with polling that exits on non-success workflow conclusions (failure/cancelled/skipped).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
This PR improves the robustness of the release flow scripts in
docs/RELEASE-FLOW.mdby: