Skip to content

Fix invalid read syntax error when result overlays are hidden #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spacebat wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix invalid read syntax error when result overlays are hidden #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b29d475
Prevent result overlays from causing subprocess failure
spacebat Nov 12, 2020
ae69841
ert-deftest test-org-babel-hide-result-overlays-suppressed
spacebat Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ob-async.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ block."
(setq exec-path ',exec-path)
(setq load-path ',load-path)
;; setq any variables that are prefixed with "org-babel-"
,(async-inject-variables "\\borg-babel.+")
,(async-inject-variables "\\borg-babel.+" nil "^org-babel-hide-result-overlays$")
(package-initialize)
(setq ob-async-pre-execute-src-block-hook ',ob-async-pre-execute-src-block-hook)
(run-hooks 'ob-async-pre-execute-src-block-hook)
Expand Down
17 changes: 17 additions & 0 deletions test/ob-async-test.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,3 +442,20 @@ inherited by the async subprocess"
(ctrl-c-ctrl-c-with-callbacks
:pre (should (placeholder-p (results-block-contents)))
:post (should (string= "I should be set!" (results-block-contents)))))))))

(ert-deftest test-org-babel-hide-result-overlays-suppressed ()
"Test that org-babel-hide-result-overlays is not inherited by
the async subprocess"
(let* ((uuid (ob-async--generate-uuid))
(buffer-contents "
#+BEGIN_SRC emacs-lisp :async
org-babel-hide-result-overlays
#+END_SRC"))
(unwind-protect
(progn
(with-buffer-contents buffer-contents
(setq org-babel-hide-result-overlays (list (make-overlay 1 1)))
(org-babel-next-src-block)
(ctrl-c-ctrl-c-with-callbacks
:pre (should (placeholder-p (results-block-contents)))
:post (should (string= "nil" (results-block-contents)))))))))