fix: expand org-babel-async insert async insert form#88
Open
vidbina wants to merge 1 commit intoastahlman:masterfrom
Open
fix: expand org-babel-async insert async insert form#88vidbina wants to merge 1 commit intoastahlman:masterfrom
vidbina wants to merge 1 commit intoastahlman:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumped into the following issue:
I reckon that the symbol is unknown in the async process since binding of a value to the symbol happens outside of the lambdas. Within the definition of
ob-async-org-babel-execute-src-block, most let-bound symbols are resolved using substitution (e.g.:,SYMBOL-NAME) to ensure that the values known to the caller are expanded into the forms in the callees (async handlers/lambdas).Very curious to have more guidance on how to resolve the issue in a "cleaner" manner in case I'm approaching "patching this" in a suboptimal manner.