Skip to content

stl: improve error messages #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 3, 2025
Merged

stl: improve error messages #128

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8680c09
stl: improve error messages
dlecorfec Aug 26, 2025
83deaf3
stl: ignore atoi errors when parsing totalNumberOfDisks and diskSeque…
dlecorfec Sep 12, 2025
0bad274
Merge branch 'asticode:master' into improve-stl-errors
dlecorfec Oct 29, 2025
84de720
stl: ignore revisionNumber parsing errors, as this field is useless i…
dlecorfec Oct 29, 2025
71ea754
stl: restore astisub prefix in error messages
dlecorfec Oct 30, 2025
fb69b01
parseDurationSTL: restore astisub prefix
dlecorfec Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 18 additions & 21 deletions stl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,96 +444,93 @@ func parseGSIBlock(b []byte) (g *gsiBlock, err error) {
// Creation date
if v := strings.TrimSpace(string(b[224:230])); len(v) > 0 {
if g.creationDate, err = time.Parse("060102", v); err != nil {
err = fmt.Errorf("astisub: parsing date %s failed: %w", v, err)
err = fmt.Errorf("astisub: parsing creationDate %s failed: %w", v, err)
return
}
}

// Revision date
if v := strings.TrimSpace(string(b[230:236])); len(v) > 0 {
if g.revisionDate, err = time.Parse("060102", v); err != nil {
err = fmt.Errorf("astisub: parsing date %s failed: %w", v, err)
err = fmt.Errorf("astisub: parsing revisionDate %s failed: %w", v, err)
return
}
}

// Revision number
if v := strings.TrimSpace(string(b[236:238])); len(v) > 0 {
if g.revisionNumber, err = strconv.Atoi(v); err != nil {
err = fmt.Errorf("astisub: atoi of %s failed: %w", v, err)
return
}
g.revisionNumber, _ = strconv.Atoi(v)
}

// Total number of TTI blocks
if v := strings.TrimSpace(string(b[238:243])); len(v) > 0 {
if g.totalNumberOfTTIBlocks, err = strconv.Atoi(v); err != nil {
err = fmt.Errorf("astisub: atoi of %s failed: %w", v, err)
err = fmt.Errorf("astisub: totalNumberOfTTIBlocks atoi of %s failed: %w", v, err)
return
}
}

// Total number of subtitles
if v := strings.TrimSpace(string(b[243:248])); len(v) > 0 {
if g.totalNumberOfSubtitles, err = strconv.Atoi(v); err != nil {
err = fmt.Errorf("astisub: atoi of %s failed: %w", v, err)
err = fmt.Errorf("astisub: totalNumberOfSubtitles atoi of %s failed: %w", v, err)
return
}
}

// Total number of subtitle groups
if v := strings.TrimSpace(string(b[248:251])); len(v) > 0 {
if g.totalNumberOfSubtitleGroups, err = strconv.Atoi(v); err != nil {
err = fmt.Errorf("astisub: atoi of %s failed: %w", v, err)
err = fmt.Errorf("astisub: totalNumberOfSubtitleGroups atoi of %s failed: %w", v, err)
return
}
}

// Maximum number of displayable characters in any text row
if v := strings.TrimSpace(string(b[251:253])); len(v) > 0 {
if g.maximumNumberOfDisplayableCharactersInAnyTextRow, err = strconv.Atoi(v); err != nil {
err = fmt.Errorf("astisub: atoi of %s failed: %w", v, err)
err = fmt.Errorf("astisub: maximumNumberOfDisplayableCharactersInAnyTextRow atoi of %s failed: %w", v, err)
return
}
}

// Maximum number of displayable rows
if v := strings.TrimSpace(string(b[253:255])); len(v) > 0 {
if g.maximumNumberOfDisplayableRows, err = strconv.Atoi(v); err != nil {
err = fmt.Errorf("astisub: atoi of %s failed: %w", v, err)
err = fmt.Errorf("astisub: maximumNumberOfDisplayableRows atoi of %s failed: %w", v, err)
return
}
}

// Timecode start of programme
if v := strings.TrimSpace(string(b[256:264])); len(v) > 0 {
if g.timecodeStartOfProgramme, err = parseDurationSTL(v, g.framerate); err != nil {
err = fmt.Errorf("astisub: parsing of stl duration %s failed: %w", v, err)
err = fmt.Errorf("astisub: parsing of timecodeStartOfProgramme duration %s failed: %w", v, err)
return
}
}

// Timecode first in cue
if v := strings.TrimSpace(string(b[264:272])); len(v) > 0 {
if g.timecodeFirstInCue, err = parseDurationSTL(v, g.framerate); err != nil {
err = fmt.Errorf("astisub: parsing of stl duration %s failed: %w", v, err)
err = fmt.Errorf("astisub: parsing of timecodeFirstInCue duration %s failed: %w", v, err)
return
}
}

// Total number of disks
if v := strings.TrimSpace(string(b[272])); len(v) > 0 {
if g.totalNumberOfDisks, err = strconv.Atoi(v); err != nil {
err = fmt.Errorf("astisub: atoi of %s failed: %w", v, err)
return
g.totalNumberOfDisks = 1
err = nil
}
}

// Disk sequence number
if v := strings.TrimSpace(string(b[273])); len(v) > 0 {
if g.diskSequenceNumber, err = strconv.Atoi(v); err != nil {
err = fmt.Errorf("astisub: atoi of %s failed: %w", v, err)
return
g.diskSequenceNumber = 1
err = nil
}
}
return
Expand Down Expand Up @@ -587,28 +584,28 @@ func parseDurationSTL(i string, framerate int) (d time.Duration, err error) {
// Parse hours
var hours, hoursString = 0, i[0:2]
if hours, err = strconv.Atoi(hoursString); err != nil {
err = fmt.Errorf("astisub: atoi of %s failed: %w", hoursString, err)
err = fmt.Errorf("astisub: hours atoi of %s failed: %w", hoursString, err)
return
}

// Parse minutes
var minutes, minutesString = 0, i[2:4]
if minutes, err = strconv.Atoi(minutesString); err != nil {
err = fmt.Errorf("astisub: atoi of %s failed: %w", minutesString, err)
err = fmt.Errorf("astisub: minutes atoi of %s failed: %w", minutesString, err)
return
}

// Parse seconds
var seconds, secondsString = 0, i[4:6]
if seconds, err = strconv.Atoi(secondsString); err != nil {
err = fmt.Errorf("astisub: atoi of %s failed: %w", secondsString, err)
err = fmt.Errorf("astisub: seconds atoi of %s failed: %w", secondsString, err)
return
}

// Parse frames
var frames, framesString = 0, i[6:8]
if frames, err = strconv.Atoi(framesString); err != nil {
err = fmt.Errorf("astisub: atoi of %s failed: %w", framesString, err)
err = fmt.Errorf("astisub: frames atoi of %s failed: %w", framesString, err)
return
}

Expand Down