[ty] Remove ClassBase::TypedDict
#22346
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diagnostic diff on typing conformance testsNo changes detected when running ty on typing conformance tests ✅ |
charliermarsh
force-pushed
the
charlie/typed-mro
branch
from
d01f09c to
d60935b
Compare
|
Member
Author
|
The |
Member
It's probably an issue due to typeshed telling us that Other type checkers do seem to issue these violations less frequently than ty (and we should look into why), but ultimately there's not much to be done about these. Typeshed has to pretend that I'm actually more concerned about the autosplit diagnostic. I don't think overriding |
Member
Author
|
Will look into it! |
Member
Author
|
@oconnor663 is part-way through astral-sh/ty#2277 so I'll just wait for that then rebase. |
Member
Author
|
For the generic issue... would it make sense to add something like the following to if remaining_bases.contains(&Type::SpecialForm(SpecialFormType::TypedDict)) {
return; // dict (from TypedDict) will bring in Generic
} |
Member
|
I don't think so -- that doesn't look like it's what the runtime does? The issue is that if >>> from typing import Generic, TypeVar
>>> K = TypeVar("K")
>>> V = TypeVar("V")
>>> class dict(Generic[K, V]): ...
...
>>> BoolOrNoneT = TypeVar('BoolOrNoneT', bound=bool|None)
>>> class TypedDict(dict): ...
...
>>> class _BasePermissionsKwargs(Generic[BoolOrNoneT], TypedDict): ...
...
Traceback (most recent call last):
File "<python-input-6>", line 1, in <module>
class _BasePermissionsKwargs(Generic[BoolOrNoneT], TypedDict): ...
TypeError: Cannot create a consistent method resolution order (MRO) for bases Generic, TypedDict |
Contributor
|
charliermarsh
force-pushed
the
charlie/typed-mro
branch
from
d60935b to
1886c7f
Compare
charliermarsh
requested review from
AlexWaygood,
carljm,
dcreager and
sharkdp
as code owners
CodSpeed Performance ReportMerging #22346 will not alter performanceComparing Summary
Footnotes
|
charliermarsh
force-pushed
the
charlie/typed-mro
branch
from
1886c7f to
43892b1
Compare
charliermarsh
force-pushed
the
charlie/typed-mro
branch
from
43892b1 to
44a938a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is likely present for a reason that I don't understand, but this removes some special-casing, better models runtime behavior (
dictin the MRO), and enables proper override checking. For reasons that (unfortunately) won't be clear in this PR, I believe this will also make functional TypedDict support a little simpler, since we can avoid extra TypedDict special-cases inClassMemberResultandInstanceMemberResult.