Multiple small improvements #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 9, 2012 00:20
(1) cgroup path update (/sys/fs/cgroups);
(2) clear screen before each iteration;
(3) drop all the ancient records like temporary cgroup
data and stopped/destroyed containers;
(4) signal handling to avoid the ugly exception
when exitting via ^C interrupt;
Owner
|
Great that this little hack actually receives pull requests. Tell me if it's urgent, otherwise I'll merge it after my holiday. |
Author
|
No problem, I'll stay with my own fork ;-) BTW, since LXC still has not so much good tools yet, I think it's valuable to share almost anything, even if it is only hack or seed for something more complex! |
Author
|
Hmm, I've just tested it on 3.2.x kernel and it seems the /sys/fs/cgroup tree structure has significantly changed :-( |
Owner
|
Despite that the kernel side is being developed in mainline, I found lxc to be a very much moving target. My target is at least 3.x, with focus on the latest version (currently 3.5). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) cgroup path update (/sys/fs/cgroups);
(2) clear screen before each iteration;
(3) drop all the ancient records like temporary cgroup
data and stopped/destroyed containers;
(4) signal handling to avoid the ugly exception
when exitting via ^C interrupt;