Net::HTTP.SOCKSProxy auth support, take 2

[musybite]

This MR is inspired by #24, but does not use thread-local variables to store username/password. This is IMO safest and cleanest way to do it.

[technoweenie]

Hi, I'd like to see this in a socksify release so I can use it in Faraday. I don't personally use a SOCKS proxy, but I have successfully tested it in my integration suite with Faraday and a golang socks server.

Is there any way I can help get this out?

/cc Integration test suite PR: technoweenie/faraday-live#7
/cc Faraday PR: lostisland/faraday#992

[guivinicius]

is this good to go?

[gcolson]

Same question as @guivinicius : what is preventing this PR from being merged for so long ?

[iMacTia]

Is there anything we can do to move this forward?

[top4ek]

Is that dead?

[astro]

Who wants to become maintainer?

[MatzFan]

@astro if you are still looking for a maintainer for socksify I'm happy to give it a go.

[astro]

@MatzFan Thanks. Please be kind to my baby. ;-)

[MatzFan]

With 40M downloads from rubygems.org I could hardly do otherwise :-)

[astro]

Oh, I was not aware.

In that case I would like to read all changes before publishing to rubygems.org. Please ping me whenever you tag a release.

[MatzFan]

@astro sure, will do.

[basex]

Can this be merged? Works well.

[anton-smagin]

Looks like a solid solution. Do you have any blockers to release this?

[astro]

I eventually rebased this one but the linter isn't happy and there are no tests for the new functionality.

Before I merge I'd love to get some review and suggestions by you who are more versed with contemporary Ruby practices.

[MatzFan]

The lack of a test facility for socks authentication was my only objection to adding this functionality, but someone further down that thread said it can be done with SSH. I'll take a look, this is long overdue.

[anton-smagin]

Hey @MatzFan @astro I added some tests for auth. CI build is 🟢.

you can take a look it here #62