fix: eval_grad_tree_array works with SubArray inputs#566
Open
MilesCranmerBot wants to merge 2 commits intoastroautomata:masterfrom
Open
fix: eval_grad_tree_array works with SubArray inputs#566MilesCranmerBot wants to merge 2 commits intoastroautomata:masterfrom
MilesCranmerBot wants to merge 2 commits intoastroautomata:masterfrom
Conversation
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
f38398c to
180a4b3
Compare
Contributor
Author
|
Resumed this branch and revalidated it against current master. What changed:
Local verification:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
180a4b3 to
1b3a01c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash when calling
eval_grad_tree_arraywithX::SubArray(e.g.view(dataset.X, :, idx)used by batching/custom losses).Empirical reproducer (on master):
eval_grad_tree_array(tree, view(X, :, idx), options; variable=true)throws aTypeErrorbecause we typeassert the gradient totypeof(X).Adjoint{T, Matrix{T}}gradient for SubArray inputs.Change:
InterfaceDynamicExpressions.eval_grad_tree_arraytoAbstractMatrix{eltype(X)}.eval_grad_tree_arrayonview(X, :, idx)and compares against Zygote.Related: #362.