Closed
Conversation
Contributor
|
Hey @eteq, are you familiar with this kind of failure, which seems to stem from unit comparison, and is unique to the numpy 1.7 build? |
Closed
astroplan/tests/test_scheduling.py
Outdated
| transitioner) | ||
| schedule2 = scheduler2(block) | ||
| assert len(schedule2.observing_blocks) == 0 | ||
| ''' |
Contributor
There was a problem hiding this comment.
Is this waiting on another PR?
Contributor
Author
There was a problem hiding this comment.
Yes, #213, without the speedup of the MoonIlluminationConstraint it takes really long.
…r and scheduler errors
Merged
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have written tests for various parts of the scheduling as well as fixed a couple of errors that showed up as I was testing.