two functions for rescaling

[kvyh]

This is an alternate form of #228, with different functions for when the score gets better or worse for larger values. Would this be better than the single function in #228?

[kvyh]

min_value, max_value and best_value, worst_value are both easy to understand, the issue I'm having is in naming the regions beyond the best and worst values. The options I've though of are: (greater_than, less_than) ; (above_max, below_min) ; (better_than , worse_than) ; (beyond_best , beyond_worst). The first two are for min,max and latter two are for best,worst.

[bmorris3]

Would you add a note on this in the User-Defined Constraint tutorial?

[eteq]

How about naming the last two arguments (which might be just one if you make the changes I'm about to discuss in the comments) as "greater_score or similar? That makes it clearer that you're saying what the output is, rather than what input value is.

Similarly, perhaps you should use the word "score" in the docstring. E.g.

Rescales the input array ``vals`` to be a score (between zero and one), where ``min_val`` 
is the best and ``max_val`` is whatever ``greater_score`` is. 

[eteq]

This was discussed in a google hangout, but just to leave a note here on the topic: I'd suggest dropping the argument of whichever of greater_than/less_than has a default of 0. The reasoning here is that for a function named e.g. min_best_rescale, it won't ever make sense for values greater than max_val to be something other than 0. In contrast, less_than is still useful because sometimes you want values below that to be 0 but other times you might want it to be 1.

In general, though, I'm 👍 on having the two separate functions. Much easier to understand.

[kvyh]

I changed the docstring. I still need to add it into the constraints tutorial.

[kvyh]

I changed the constraint tutorial to contain a non-boolean constraint that uses the min_best_rescale

[bmorris3]

Would you put double ticks around min_val on this line?

[kvyh]

I changed the parameter types to "array-like" and "float" and ``ed the min_val and max_val.

[bmorris3]

Thanks @kvyh!