enforce upper limit on MastMissions query radius #3447
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorris3
force-pushed
the
mastmissions-radius-limit
branch
from
811e732 to
0204c54
Compare
bmorris3
force-pushed
the
mastmissions-radius-limit
branch
from
0204c54 to
941a111
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3447 +/- ##
=======================================
Coverage 70.72% 70.73%
=======================================
Files 232 232
Lines 20041 20046 +5
=======================================
+ Hits 14174 14179 +5
Misses 5867 5867 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
snbianco
reviewed
Oct 24, 2025
CHANGES.rst
Outdated
| - Filtering by file extension or by a string column is now case-insensitive in ``MastMissions.filter_products`` | ||
| and ``Observations.filter_products``. [#3427] | ||
|
|
||
| - Raise informative error if MastMissions query radius is too large. [#3447] |
There was a problem hiding this comment.
Nitpick, but could you put MastMissions in double backticks? Just so users know that we're referring to a class.
astroquery/mast/missions.py
Outdated
| Raises | ||
| ------ | ||
| InvalidQueryError | ||
| If the query radius is larger than the limit (30 arcminute). |
There was a problem hiding this comment.
Should be "30 arcminutes" in parentheses.
astroquery/mast/missions.py
Outdated
| Raises | ||
| ------ | ||
| InvalidQueryError | ||
| If the query radius is larger than the limit (30 arcminute). |
snbianco
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
astroquery.mast.MastMissionssupportsquery_regionandquery_criteriawithradius <= 0.5 * u.deg. The current uninformative error message whenradius > 0.5 * u.degcomes fromPOST.This PR adds the radius limitation to the docstrings, and raises an
InvalidQueryErrorifradius > 0.5 * u.deg.