feat: use nuxt-site-config module if available for origin extraction#501
Open
astraldev wants to merge 1 commit intoatinux:mainfrom
Open
feat: use nuxt-site-config module if available for origin extraction#501astraldev wants to merge 1 commit intoatinux:mainfrom
astraldev wants to merge 1 commit intoatinux:mainfrom
Conversation
Owner
|
Not sure I am happy with this approach, most people use the |
Author
|
Understandable, if the module itself can have support for a base url, then there would be no need for it. I picked it since the Would you prefer I clone it instead (only the relevant part)? So we don't rely on that? It's quite strange, we have to configure the redirect url for each oauth provider manually. Using the |
Owner
|
But my main concern is why the current behavior does not work for you @astraldev? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500
I've added an extra plugin to check if nuxt site config is available, and use it's
getNitroOrigincomposable at thegetOAuthRedirectURLmethod