Fix Position model for Kalshi API schema change#2
Open
ianjamesburke wants to merge 1 commit intoaustron24:mainfrom
Open
Fix Position model for Kalshi API schema change#2ianjamesburke wants to merge 1 commit intoaustron24:mainfrom
ianjamesburke wants to merge 1 commit intoaustron24:mainfrom
Conversation
Kalshi changed their positions API to return string fixed-point values (position_fp, market_exposure_dollars, realized_pnl_dollars, etc.) instead of integer cents (position, market_exposure, realized_pnl). This updates the Position model to accept both formats, backfilling the legacy integer fields from the new string fields via model_post_init so all existing code continues to work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
position_fp,market_exposure_dollars,realized_pnl_dollars,total_traded_dollars,fees_paid_dollars) instead of integer cents (position,market_exposure,realized_pnl,total_traded)summary,positions,status) with:Field requiredforpositionPositionmodel to accept both the new and legacy formats, backfilling the legacy integer fields viamodel_post_initso all existing code continues to workTest plan
kalshi summary— was broken, now workskalshi positions— works, shows correct exposure/P&Lkalshi status— works, shows correct position count and exposure