fix: handle detailedResponse in HTTP interceptor (#731) #752
+112
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using detailedResponse: true in httpInterceptor tokenOptions, the interceptor was attempting to use the entire response object as the Authorization header value, resulting in 'Bearer [object Object]'. This fix extracts the access_token property from the detailed response object when present, while maintaining backward compatibility with the default string token response. Fixes #731
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes HTTP interceptor to correctly extract access token when
detailedResponse: trueis used intokenOptions.Closes #731
Problem
When
detailedResponse: trueis set,getTokenSilently()returns an object containingaccess_token,token_type, etc. The interceptor was passing this entire object to the Authorization header, resulting inBearer [object Object].Solution
Added type checking to extract
access_tokenfrom the response object when needed, while maintaining backward compatibility with string tokens.Changes
getAccessTokenSilently()inauth.interceptor.tsto handle both string and object responsesTesting
Verified the Authorization header is correctly set in both scenarios:
detailedResponse: true- Now sends the actual token instead of[object Object]detailedResponse- Continues to work as before (no breaking changes)