This repository was archived by the owner on Jun 4, 2025. It is now read-only.
fix: carry over fixed_window attribute to overrides #91
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
We realised that overriding limits seemed to bring back the sliding window behaviour if the limit was set to fixed_window:
During testing we created an override setting the limit to 100 RPS. The moment the override hit the configuration, the behavior changed, we saw the sliding window behavior back in place.
After removing the override we were back to the fixed_window behavior.
References
Testing
Tested live after applying an override:
Checklist