migration: slow down migration on s390x #6709
Conversation
WalkthroughThis pull request modifies 18+ libvirt test configuration files across the migration directory. The changes consistently add s390-virtio variant entries to existing migration test configurations, introducing virsh_migrate_options with bandwidth settings under both p2p and non_p2p variants. Bandwidth values range from 50 to 100 depending on the specific test. Some files additionally modify migrate_speed or virsh_migrate_extra fields for s390-virtio-specific test scenarios. All changes are additive and configuration-only, without altering existing variant logic. Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (19)
🧰 Additional context used🧠 Learnings (3)📓 Common learnings📚 Learning: 2025-12-12T10:00:09.383ZApplied to files:
📚 Learning: 2025-11-24T10:44:47.801ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🔇 Additional comments (22)
Comment |
smitterl
force-pushed
the
slow_down_migration_s390x
branch
from
3651e2f to
3b29d42
Compare
smitterl
force-pushed
the
slow_down_migration_s390x
branch
4 times, most recently
from
ce0b076 to
e00bd62
Compare
On our s390x systems some checks fail consistently because the migration finishes before the check is started. Slow the migration down as usual via bandwidth parameter. Given the additional non-default bandwidth, migration_precopy_bandwidth.set_bandwidth_when_vm_shutoff will test for the wrong bandwidth setup. Fix the value. migration_precopy_bandwidth.set_bandwidth_when_initiating_live_migration similarly will use another bandwidth parameter and the extra option is unnecessary. Fix the values.
On our s390x systems some checks fail consistently because the migration finishes before the check is started. Slow the migration down as usual via bandwidth parameter. Some test case already sets that parameter for precopy explicitly so need to remove it for s390x.
On our s390x systems some checks fail consistently because the migration finishes before the check is started. Slow the migration down as usual via bandwidth parameter.
On our s390x systems some checks fail consistently because the migration finishes before the check is started. Slow the migration down as usual via bandwidth parameter. Signed-off-by: Sebastian Mitterle <smitterl@redhat.com>
On our s390x systems some checks fail consistently because the migration finishes before the check is started. Slow the migration down as usual via bandwidth parameter. Signed-off-by: Sebastian Mitterle <smitterl@redhat.com>
On our s390x systems some checks fail consistently because the migration finishes before the check is started. Slow the migration down as usual via bandwidth parameter. Signed-off-by: Sebastian Mitterle <smitterl@redhat.com>
On our s390x systems some checks fail consistently because the migration finishes before the check is started. Slow the migration down as usual via bandwidth parameter. Signed-off-by: Sebastian Mitterle <smitterl@redhat.com>
smitterl
force-pushed
the
slow_down_migration_s390x
branch
from
e00bd62 to
b0b4de1
Compare
1 participant
Several test cases fail because the migration finishes before checks are executed. As usual, slow down these migrations with the bandwidth parameter.
We might have solved this, too, by setting these values downstream only with string replacement but this can lead to conflicts per test case as we only substitute lines.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.