Skip to content

Migrate netperf perf tests from tp-qemu to tp-libvirt #6743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quanwenli wants to merge 1 commit into
base: master
Choose a base branch
from
+1,796 −0
Open

Migrate netperf perf tests from tp-qemu to tp-libvirt #6743

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 148 additions & 0 deletions libvirt/tests/cfg/virtual_network/qemu/netperf.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,148 @@
- virtual_network.qemu_test.netperf: image_copy
create_vm_libvirt = yes
master_images_clone = img1
remove_image_image1 = yes
main_vm = vm1
vms = ${main_vm}
kill_vm_libvirt = yes
ovmf:
kill_vm_libvirt_options = --nvram
virt_test_type = libvirt
type = netperf
not_preprocess = yes
image_snapshot = yes
setup_ksm = no
take_regular_screendumps = no
store_vm_register = no
# sometimes since vm performance issue or processors could not handle
# at same time with mis-config sessions number, it may not all clients
# up at same times, please modify tires parameter to repeat sub tests
# to increase the successful probalility
tries = 5
# Please update following comments params when you need special cfg for
# your test nic cards
# nic1 is for control, nic2 is for data connection
nics += ' nic2'
# queues = 4
enable_msix_vectors = yes
#Configure different types of network adapters.
nic_model_nic1 = virtio
nic_model_nic2 = virtio
i386, x86_64:
nic_model_nic2 = e1000
netdst_nic1 = private
netdst_nic2 = switch
# please fix the mac for nic2 if you needed with this, this can be empty
# nic_mac_nic2 =
# please add the physical nic you want to add to your private bridge
# this can be empty
# physical_nic =
# bridge_force_create=yes
# bridge_nic1 =
#numa configration
netperf_with_numa = yes
vdpa_add_flows = yes
# configure netperf test parameters, some seconds will be took to
# wait all the clients work, this wait time should be less than
# 0.5 * l, the wait time will augments if you have move
# threads. So experientially suggest l should be not less than 60.
l = 60
#Test protocol and test data configration
protocols = "TCP_STREAM TCP_MAERTS TCP_RR"
sessions = "1 2 4 8"
sessions_rr = "1 25 50"
sizes = "64 256 1024 4096 16384 65535"
sizes_rr = "64 256 4096"
#client configuration
client = localhost
username_client = root
password_client = 123456
shell_client_client = ssh
shell_port_client = 22
shell_prompt_client = \[root@.{0,50}][\#\$]
#host configuration
shell_port_host = 22
password_host = 123456
username_host = root
os_type_client = linux
os_type_host = linux
shell_prompt_host = \[root@.{0,50}][\#\$]
#Test base env configration
ver_cmd = rpm -q qemu-kvm
netperf_version = 2.7.1
netperf_pkg = netperf/netperf-2.7.1.tar.bz2
setup_cmd = "cd /tmp && rm -rf netperf-2.7.1 && tar xvfj netperf-2.7.1.tar.bz2 && cd netperf-2.7.1 && sh autogen.sh && CFLAGS=-Wno-implicit-function-declaration ./configure --enable-burst --enable-demo=yes && make"
ppc64:
setup_cmd = "cd /tmp && rm -rf netperf-2.7.1 && tar xvfj netperf-2.7.1.tar.bz2 && cd netperf-2.7.1 && sh autogen.sh && CFLAGS=-Wno-implicit-function-declaration ./configure --build=ppc64 --enable-burst --enable-demo=yes && make"
ppc64le:
setup_cmd = "cd /tmp && rm -rf netperf-2.7.1 && tar xvfj netperf-2.7.1.tar.bz2 && cd netperf-2.7.1 && sh autogen.sh && CFLAGS=-Wno-implicit-function-declaration ./configure --build=ppc64le --enable-burst --enable-demo=yes && make"
log_hostinfo_script = scripts/rh_perf_log_hostinfo_script.sh
host_tuned_profile = "tuned-adm profile virtual-host"
client_tuned_profile = "tuned-adm profile virtual-host"
client_kill_linux = "killall netperf"
client_kill_windows = "taskkill /F /IM netperf*"
# Now the get status functions are implemented for RHEL and Fedora guests.
# Not test with other guests, please set this depends on your guest os
# environment.
RHEL, Fedora:
get_status_in_guest = yes
Linux:
# log_guestinfo_script = scripts/rh_perf_log_guestinfo_script.sh
# log_guestinfo_exec = bash
# log_guestinfo_path = /tmp/log_guestinfo.sh
server_tuned_profile = "tuned-adm profile virtual-guest"
server_mtu_cmd = "ifconfig %s mtu %s"
Windows:
# log_guestinfo_script = scripts/rh_perf_log_guestinfo_script.bat
# log_guestinfo_exec = cmd /c
# log_guestinfo_path = C:\log_guestinfo.bat
server_mtu_cmd = "netsh interface ipv4 set interface "%s" mtu=%s"
Copy link

@coderabbitai coderabbitai bot Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Windows MTU command has mismatched quotes.

The command string has an opening " before %s but no matching close before the second %s, which will cause the command to fail on Windows.

🔎 Proposed fix 
-        server_mtu_cmd = "netsh interface ipv4 set interface "%s" mtu=%s"
+        server_mtu_cmd = "netsh interface ipv4 set interface \"%s\" mtu=%s"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
server_mtu_cmd = "netsh interface ipv4 set interface "%s" mtu=%s"
server_mtu_cmd = "netsh interface ipv4 set interface \"%s\" mtu=%s"
🤖 Prompt for AI Agents 
In libvirt/tests/cfg/virtual_network/qemu/netperf.cfg around line 99, the
server_mtu_cmd string has mismatched quotes around the interface placeholder
("%s"); fix by ensuring the inner quotes are escaped or by using single quotes
for the outer string so the command becomes e.g. "netsh interface ipv4 set
interface \"%s\" mtu=%s" or 'netsh interface ipv4 set interface "%s" mtu=%s' so
the interface name is properly quoted.

i386, x86_64:
cpu_model_flags = ",hv_time,hv_relaxed,hv_vapic,hv_spinlocks=0xfff"
windows_disable_firewall = "netsh advfirewall set allprofiles state off"
devcon_dirname = "win7_"
i386:
devcon_dirname += "x86"
x86_64:
devcon_dirname += "amd64"
client_mtu_cmd = "ifconfig %s mtu %s"
host_mtu_cmd = "ifconfig %s mtu %s"
#FIXME: it's a workaround, it needs a better way to disable all the firewall rules
env_setup_cmd = "systemctl stop firewalld.service ; service iptables stop ; iptables -F ; nft flush ruleset;"
env_setup_cmd += " echo 2 > /proc/sys/net/ipv4/conf/all/arp_ignore;"
env_setup_cmd += " echo 0 > /sys/kernel/mm/ksm/run;"
env_setup_cmd += " echo 0 > /proc/sys/kernel/watchdog;"
env_setup_cmd += " echo 0 > /proc/sys/kernel/nmi_watchdog;"
env_setup_cmd += " setenforce 1"
variants:
- host_guest:
Windows:
netserv_start_cmd = "start /b %s:\netserver-2.6.0.exe"
guest_ver_cmd = "ver"
use_cygwin = no
variants:
- @default_setting:
Linux:
no Jeos
# to test exthost <-> guest:
# client = <external host's private ip>
# client_public_ip = <external host's public ip>
# server_private_ip = <netperf server's private ip>
Windows:
#client = <external host/guest ip>
config_cmds = driver_verifier_query
driver_verifier_query = "verifier /querysettings"
reboot_after_config = yes
install_vioprot_cmd = "netcfg -v -l %s -c p -i VIOPROT"
cdroms += " virtio winutils"
virtio_win_media_type = iso
driver_name = netkvm VIOPROT
devcon_path = "WIN_UTILS:\devcon\${devcon_dirname}\devcon.exe"
device_name = "Red Hat VirtIO Ethernet Adapter"
device_hwid = '"PCI\VEN_1AF4&DEV_1000" "PCI\VEN_1AF4&DEV_1041"'
variants:
- with_jumbo:
mtu = 9000
# please config physical nic name of client for jumbo frame case by uncommenting it
# client_physical_nic = <your_client_physical_nic>
- default:
Loading