Skip to content

win_guest_debugging_tool: Optimize and simplify script #4417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
6-dehan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

win_guest_debugging_tool: Optimize and simplify script #4417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
957594a
win_guest_debugging_tool: Optimize and simplify script
6-dehan Dec 9, 2025
b4e4f2c
win_guest_debugging_tool.py: Add new case for MTV Firstboot log
6-dehan Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions qemu/tests/cfg/win_guest_debugging_tool.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,15 @@
cdrom_virtio = isos/windows/virtio-win.iso
cmd_findstr_in_file = type %s | findstr "%s"
include_sensitive_data = False
script_execution_timeout = 720
target_files = "msinfo32.txt,system.evtx,security.evtx,application.evtx,drv_list.csv,virtio_disk.txt,WindowsUpdate.log,Services.csv,WindowsUptime.txt,RunningProcesses.csv,InstalledApplications.csv,InstalledKBs.csv,NetworkInterfaces.txt,IPConfiguration.txt,setupapi.dev.log,setupapi.setup.log,setupapi.offline.log,ErrorWindowsUpdate.log,OutputWindowsUpdate.log,LocaleMetaData"
target_dump_files = "MEMORY.DMP,Minidump"
script_name = "CollectSystemInfo.ps1"
cmd_search_file_global = powershell.exe -Command "Get-PSDrive -PSProvider FileSystem | ForEach-Object { Get-ChildItem -Path $_.Root -Recurse -Filter '%s' -ErrorAction SilentlyContinue } | ForEach-Object { Join-Path -Path $_.Directory.FullName -ChildPath $_.Name }"
Win2016:
script_execution_timeout = 1200
cmd_disable_ie_esc_admin = powershell.exe -Command "Set-ItemProperty -Path 'HKLM:\SOFTWARE\Microsoft\Active Setup\Installed Components\{A509B1A7-37EF-4b3f-8CFC-4F3A74704073}' -Name 'IsInstalled' -Value 0"
cmd_disable_ie_esc_user = powershell.exe -Command "Set-ItemProperty -Path 'HKLM:\SOFTWARE\Microsoft\Active Setup\Installed Components\{A509B1A8-37EF-4b3f-8CFC-4F3A74704073}' -Name 'IsInstalled' -Value 0"
Comment on lines +21 to +24
Copy link
Contributor

@leidwang leidwang Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we dicsussed offline, it would be better to break down current commit, it would be more clear.

Copy link
Contributor Author

@6-dehan 6-dehan Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'll split another one, as for this one, just keep it here this time. thanks

variants:
- check_script_execution:
windegtool_check_type = script_execution
Expand All @@ -29,7 +34,7 @@
- check_user_friendliness:
windegtool_check_type = user_friendliness
cmd_kill_powershell_process = taskkill /IM powershell.exe /F
cmd_kill_powershell_process1 = powershell.exe -Command "Stop-Process -Name msinfo32 -Force"
cmd_kill_powershell_process1 = powershell.exe -Command "Stop-Process -Name msinfo32 -Force -ErrorAction SilentlyContinue"
invalid_params = "-invalidparam,IncludeSensitiveData,0000,hell,-H,-IncludeSensitiveData -h"
expect_output_prompt = "Usage: .\CollectSystemInfo.ps1 [-IncludeSensitiveData] [-Help]"
script_interrupt_signal_file = 'Collecting_Status.txt'
Expand Down Expand Up @@ -67,6 +72,7 @@
setupapi_dev_file_path = "%s\setupapi.dev.log"
target_driver = pvpanic
cmd_query_oem_inf = powershell.exe -Command "pnputil.exe /enum-drivers | Select-String -Pattern '%s.inf' -Context 1,1 | ForEach-Object { if ($_ -match 'Published Name:\s+(oem\d+\.inf)') { $matches[1] } }"
cmd_disable_device = powershell.exe -Command "$d=Get-PnpDevice -ErrorAction SilentlyContinue | Where-Object {$_.FriendlyName -like '*%s*' -or $_.InstanceId -like '*%s*'}; if ($d) { $d | Disable-PnpDevice -Confirm:$false -ErrorAction SilentlyContinue }"
cmd_install_driver = pnputil.exe /add-driver %s /install
cmd_uninstall_driver = pnputil.exe /delete-driver %s /uninstall /force
cmd_scan_device = pnputil.exe /scan-devices
Expand Down Expand Up @@ -96,10 +102,19 @@
standard_docs = "README.md", "LICENSE", "CollectSystemInfo.ps1"
target_doc = "README.md"
query_cmd_from_file = powershell.exe -Command "Get-Content %s | Select-String '```powershell' -Context 0,1"
cmd_cp_file = powershell.exe -Command "cp %s %s"
cmd_cp_file = powershell.exe -Command "cp %s %s -Force"
- check_IO_limits:
windegtool_check_type = IO_limits
cmd_get_io_folder = powershell.exe -Command "Get-ChildItem -Path %s -Recurse -Filter '*IOLimits_C*' | Select-Object -ExpandProperty FullName"
cmd_fsutil = fsutil file createnew testfile.tmp 1000000000
cmd_cat_io = type %s
cmd_del_file = del testfile.tmp
- check_MTV_firstboot_log_collection:
windegtool_check_type = MTV_firstboot_log_collection
firstboot_dir = "C:\Program Files\Guestfs\Firstboot"
firstboot_file = "log.txt"
firstboot_content = "Firstboot log content: all drivers are installed successfully"
collected_file_name = "MTV_Firstboot_log.txt"
cmd_create_firstboot_dir = powershell.exe -Command "New-Item -Path '%s' -ItemType Directory -Force"
cmd_create_firstboot_file = powershell.exe -Command "Set-Content -Path '%s' -Value '%s'"
cmd_check_file_content = powershell.exe -Command "Get-Content -Path '%s'"
Loading