Feature: display banner only on the first run#62
Open
cereda wants to merge 1 commit intoavelino:mainfrom
Open
Conversation
Contributor
Author
|
Clippy works locally, so I blame GH's CI. 😅 |
avelino
requested changes
Mar 12, 2026
Owner
avelino
left a comment
There was a problem hiding this comment.
Clean implementation, follows the existing compact_banner pattern. A few points before merge:
Tests
- Missing test for happy path:
one_time_banner = truegenerating stub withJBUNDLE_RUNSand[ ! -e ... ]logic - Missing test for default case:
one_time_banner = falsenot containingJBUNDLE_RUNS - Missing test for
compact_banner = true+one_time_banner = truecombination
Cleanup of ~/.jbundle/runs/
This directory will accumulate marker files indefinitely. At minimum document this, ideally clean up alongside jbundle clean.
Race condition
If two instances of the same binary run in parallel for the first time, both pass the [ ! -e ... ] check before the touch. Banner shows up twice. No need to fix now, but document as a known limitation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully a better understanding of #39. 😉
Added
--one-time-bannertojbundle. When present, the underlying wrapper will use theapp_hashstring to look for a file of the same name inside${HOME}/.jbundle/runs. During the first app run, this file does not exist, so the banner is displayed as expected, and the file is created. Subsequent runs will check for the file, and since it exists, the banner will be omitted.I need some coffee now. ☕ 🦆