sequelize: Document postgres dialect limitations #220
+134
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfrankcom
added a commit
to awslabs/aurora-dsql-nodejs-connector
that referenced
this pull request
Dec 20, 2025
This PR adds a filter step for user configuration to strip out `null` and `undefined` values. This prevents these values from overriding default configuration. This is similar to #130 which applied to the `connectionString` config. This was found in the context of aws-samples/aurora-dsql-samples#220, as the Sequelize driver currently requires explicit `database` configuration. From what I can tell, this is because the underlying driver configures the values as `undefined` if they are not specified. When this connector change is applied, Sequelize can correctly use the DSQL defaults. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Sequelize
README.mdfile based on the results of experimenting with thepostgresdialect.The intent is to provide some more targeted guidance for specific issues users might encounter. The information from the original doc is retained, but reorganized in a few places to provide extra explanations and code snippets.
I also removed theNevermind this doesn't work, I guess I had a localdatabaseproperty from the example since it was specifying the default, which we should leave to our connector to configure for simplicity. I noticed this when reworking the connection section in theREADME.md.PGDATABASEset while testing.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 license.