Skip to content

Conversation

@nshalabh
Copy link
Contributor

@nshalabh nshalabh commented Nov 4, 2025

fix: upgrade the version of python from 3.9 to 3.12 as it is reaching EOL in Dec 2025, across all yml, tf templates, github workflows etc

Fixes #


By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

Apache 2.0 License

… EOL in Dec 2025, across all yml, tf templates, github workflows etc
…ies found during the scans, that are failing the github workflow
…(^2.5.0) that fail the github workflow checks
… to version upgrade found for black and boto3 versions, as their versions have already been upgraded; fixing argument types for ignore
… been fixed; add ignore for certain non-conclusive flake8 checks; undoing the changes for inspector.py
…es, as even after the version upgrades the vulnerabilities are not getting resolved in the github workflow
…etry for installing dependencies for fixing vulnerabilities for black and urllib versions
…n the github workflow, as it prevents the installation of secure versions of packages like black and urllib3 leading to vulnerabilities
…vulnerabilities that persist for black and urllib3 packages
… to find security vulnerabilities for urllib3 and black
…to pull_request as the vulnerability fixes due to caching of poetry.lock were not getting addressed
Copy link

@davidhessler davidhessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The biggest issue I see here is there is no dependabot.yml configuration (docs, example). I think a lot of this would have been caught by dependabot and fixed automatically.

@nshalabh nshalabh self-assigned this Nov 19, 2025
…ckov scan finding -- CKV_AWS_338: "Ensure CloudWatch log groups retains logs for at least 1 year"
…ssociated with main, and not keep using the pull_request_target
@nshalabh
Copy link
Contributor Author

nshalabh commented Nov 20, 2025

The 'safety - Python Dependency Check/Linting (3.9) (pull_request_target)' fails because this action runs on the target branch/fork i.e. main. There are two dependencies urllib3 and black whose older versions are causing vulnerabilities. The new versions have been upgraded in the solution, but since the safety check runs on target, it keeps pulling the older versions of the above packages from the cache. While the caching has been fixed in the respective GitHub workflow, it still needs to get merged to main so as to replace the pull_request_target trigger.

Also, added dependabot to automate Python upgrades in the future

@nshalabh nshalabh merged commit 21ace18 into aws-samples:main Nov 20, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants