generated from amazon-archives/__template_MIT-0
-
Notifications
You must be signed in to change notification settings - Fork 503
Multi-tenant usage of shared Knowledge Bases. #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng Step Functions.
- Backend
- Add `type` to `BedrockKnowledgeBaseModel`.
- `dedicated` or `shared` or null
- Add `BedrockKnowledgeBaseType` and `BedrockKnowledgeBaseHash` for sparse index of `BotTable`.
- When `shared` is selected, dedicated Knowledge Base is not created.
- Frontend
- Add 'Pool Pattern' selection for Knowledge settings in `BotKbEditPage`.
- Screenshot changes - docs/imgs/customized_bot_creation.png - docs/imgs/import_existing_kb.png
e02cc8e to
948e1ff
Compare
948e1ff to
59d62a8
Compare
- Omit building of shared Knowledge Bases if not necessary. - Automatically delete expired lock files using S3's lifecycle rule. - Add comments and update README.md.
Contributor
Removed pdk-nag temporarilyRemoved from cdk.test due to compatibility issues with upgraded CDK/cdk-nag versions. The old pdk-nag referenced deprecated rules, and upgrading it would require significant refactoring due to package structure changes. Removing temporarily to unblock the main upgrade. |
statefb
approved these changes
Nov 5, 2025
Contributor
statefb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #888
Description of changes:
Add 'shared' setting to Knowledge Base settings
typeto the model class that handles Knowledge Base configurationdedicated: Create a dedicated Knowledge Base for the botshared: Share a Knowledge Base with the same settings across multiple bots, separating tenants by Bot IDAssign Bot ID as metadata for files uploaded by bots
retrieverequests to the Knowledge BaseCompletely revamp the Embedding state machine
BrChatSharedKbStackBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.