feat: implement configuration profiles #436
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karenc-bq
force-pushed
the
configuration_profiles
branch
4 times, most recently
from
c4880b1 to
91ff230
Compare
karenc-bq
added
wip
karenc-bq
force-pushed
the
configuration_profiles
branch
4 times, most recently
from
c721c6f to
6933c4f
Compare
joyc-bq
reviewed
Mar 13, 2024
| def init_host_provider(self, props: Properties, host_list_provider_service: HostListProviderService, init_host_provider_func: Callable): | ||
| self._host_list_provider_service = host_list_provider_service | ||
| if host_list_provider_service.is_static_host_list_provider(): | ||
| raise AwsWrapperError(Messages.get("AuroraInitialConnectionStrategyPlugin.RequireDynamicProvider")) |
There was a problem hiding this comment.
should be also log the error with the logger here?
karenc-bq
force-pushed
the
configuration_profiles
branch
from
6933c4f to
46e2a54
Compare
joyc-bq
reviewed
Mar 20, 2024
| "random") | ||
|
|
||
| OPEN_CONNECTION_RETRY_TIMEOUT_MS = WrapperProperty("open_connection_retry_timeout_ms", | ||
| "Maximum allowed time for the retries opening a connection.", 30_000) |
There was a problem hiding this comment.
Maximum allowed time in milliseconds for the retries opening a connection.
karenc-bq
force-pushed
the
configuration_profiles
branch
from
46e2a54 to
ad3d3d1
Compare
karenc-bq
force-pushed
the
configuration_profiles
branch
from
e5816eb to
0cf3aaf
Compare
joyc-bq
reviewed
May 9, 2024
| AdfsCredentialsProviderFactory.SignOnPageRequestFailed=[AdfsCredentialsProviderFactory] ADFS SignOn Page Request Failed with HTTP status '{}', reason phrase '{}', and response '{}' | ||
| AdfsCredentialsProviderFactory.SignOnPageUrl=[AdfsCredentialsProviderFactory] ADFS SignOn URL: '{}' | ||
|
|
||
| AuroraInitialConnectionStrategyPlugin.UnsupportedStrategy=Unsupported host selection strategy '{}'. |
There was a problem hiding this comment.
Suggested change
| AuroraInitialConnectionStrategyPlugin.UnsupportedStrategy=Unsupported host selection strategy '{}'. | |
| AuroraInitialConnectionStrategyPlugin.UnsupportedStrategy=[AuroraInitialConnectionStrategyPlugin] Unsupported host selector strategy '{}'. |
joyc-bq
reviewed
May 9, 2024
| AdfsCredentialsProviderFactory.SignOnPageUrl=[AdfsCredentialsProviderFactory] ADFS SignOn URL: '{}' | ||
|
|
||
| AuroraInitialConnectionStrategyPlugin.UnsupportedStrategy=Unsupported host selection strategy '{}'. | ||
| AuroraInitialConnectionStrategyPlugin.RequireDynamicProvider=Dynamic host list provider is required. |
There was a problem hiding this comment.
Suggested change
| AuroraInitialConnectionStrategyPlugin.RequireDynamicProvider=Dynamic host list provider is required. | |
| AuroraInitialConnectionStrategyPlugin.RequireDynamicProvider=[AuroraInitialConnectionStrategyPlugin] Dynamic host list provider is required. |
joyc-bq
reviewed
May 9, 2024
|
|
||
| OPEN_CONNECTION_RETRY_TIMEOUT_MS = WrapperProperty("open_connection_retry_timeout_ms", | ||
| "Maximum allowed time in milliseconds for the retries opening a connection.", 30_000) | ||
| OPEN_CONNECTION_RETRY_INTERVAL_MS = WrapperProperty("open_connection_retry_interval_ms", "Time between each retry of opening a connection.", 1000) |
There was a problem hiding this comment.
Suggested change
| OPEN_CONNECTION_RETRY_INTERVAL_MS = WrapperProperty("open_connection_retry_interval_ms", "Time between each retry of opening a connection.", 1000) | |
| OPEN_CONNECTION_RETRY_INTERVAL_MS = WrapperProperty("open_connection_retry_interval_ms", "Time in milliseconds between each retry of opening a connection.", 1000) |
joyc-bq
reviewed
May 9, 2024
Comment on lines
+56
to
+58
| msg = Messages.get("AuroraInitialConnectionStrategyPlugin.RequireDynamicProvider") | ||
| logger.warning(msg) | ||
| raise AwsWrapperError(msg) |
There was a problem hiding this comment.
Suggested change
| msg = Messages.get("AuroraInitialConnectionStrategyPlugin.RequireDynamicProvider") | |
| logger.warning(msg) | |
| raise AwsWrapperError(msg) | |
| msg = "AuroraInitialConnectionStrategyPlugin.RequireDynamicProvider" | |
| logger.warning(msg) | |
| raise AwsWrapperError(Messages.get(msg)) |
joyc-bq
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.