feat(eks): support Kubernetes 1.34

[harryfrzz]

Issue # (if applicable)

Closes #35717.

Reason for this change

Amazon EKS and EKS Distro now support Kubernetes 1.34. Adding v1.34 to the CDK EKS module keeps CDK users aligned with the latest managed Kubernetes version and avoids manual workarounds.

Description of changes

• Add KubernetesVersion.V1_34 to EKS supported versions.
• Update kubectl asset layer to v1.34 for compatibility with cluster operations.
• Refresh integration test snapshots reflecting kubectl v1.34 outputs.

Describe any new or updated permissions being added

Description of how you validated changes

• Unit tests: Extended version to include v1.34 and ran existing EKS tests.
• Integration: Updated snapshots for kubectl v1.34

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[phuhung273]

The idea is ok, we can start updating a few things first:

• Update PR title as instructed in https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#step-4-pull-request
• For this PR and next few other PRs, I would recommend to fill all PR description to:
  • help reviewers understand what problem you're solving
  • show how you tested the change
  • Among them, only permission section is optional.
• Seems like you're using your own linter to format cluster.ts. Please don't do it as the project already has its own linter. Ideally, cluster.ts should only has the new version added.

[aws-cdk-automation]

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[phuhung273]

Singlequote in cluster.ts are all changed to doublequote, we need to use singlequote to keep the codebase consistent.

[harryfrzz]

Singlequote in cluster.ts are all changed to doublequote, we need to use singlequote to keep the codebase consistent.

Sorry, my editor automatically changed it to double quotes. Now it is fixed @phuhung273

[phuhung273]

Looking good, now we need to do the same revert all non-related whitespace, double quote change for all other ts files. I think turning off the editor linter would make things easier.

[harryfrzz]

Looking good, now we need to do the same revert all non-related whitespace, double quote change for all other ts files. I think turning off the editor linter would make things easier.

okay got it

[harryfrzz]

I think most of the files that i committed now doesn't have the issue that you stated @phuhung273
Please correct me if i'm wrong

[phuhung273]

You should be able to do a self-review here https://github.com/aws/aws-cdk/pull/35863/files

Can see lots of unrelated changes here

While it should be this simple in #33339

[harryfrzz]

What exactly should i do now, can you specify what changes have to be done
Did you mean i have to revert the changes done to files in https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-eks-v2-alpha/lib/cluster.ts and other files related to this? @phuhung273

[harryfrzz]

@pahud Can you help me out with this PR?

[pahud]

@harryfrzz I am not eligible to review the PRs but I think the feedback from @phuhung273 makes sense to me. As soon as the CodeBuild CI passes(it's failed now), this PR will get a pr/pending-community-review label and get in this queue
https://github.com/aws/aws-cdk/pulls?q=is%3Apr+is%3Aopen+label%3Apr%2Fneeds-community-review+status%3Asuccess

After any community reviewers gives an approval, it will bump to pr/pending-maintainer-reivew in this queue
https://github.com/aws/aws-cdk/pulls?q=is%3Apr+is%3Aopen+label%3Apr%2Fneeds-maintainer-review+status%3Asuccess+ and the maintainer should review your PR very soon.

┌─────────────────────────────────────────────────────────────────────┐
│                         PR REVIEW WORKFLOW                          │
└─────────────────────────────────────────────────────────────────────┘

    ┌──────────────┐
    │  PR Created  │
    └──────┬───────┘
           │
           ▼
    ┌──────────────┐
    │  CodeBuild   │
    │  CI Running  │
    └──────┬───────┘
           │
           ▼
    ┌──────────────┐         ❌ Failed
    │  CI Status?  ├─────────────────────┐
    └──────┬───────┘                     │
           │ ✅ Success                  │
           ▼                             │
    ┌──────────────────────────────┐    │
    │ pr/needs-community-review    │    │
    │ (Community Review Queue)     │◄───┘
    └──────┬───────────────────────┘
           │
           │ Community Reviewer Approves
           ▼
    ┌──────────────────────────────┐
    │ pr/needs-maintainer-review   │
    │ (Maintainer Review Queue)    │
    └──────┬───────────────────────┘
           │
           │ Maintainer Reviews
           ▼
    ┌──────────────┐
    │   Merged!    │
    └──────────────┘

[harryfrzz]

@pahud if possible, can you trigger the codebuild CI?

[phuhung273]

This is the CodeBuild CI, it is auto triggered every time you commit. You can click the link to see the error. Contributing doc has instruction on how to run it locally on your machine.

[harryfrzz]

This is the CodeBuild CI, it is auto triggered every time you commit. You can click the link to see the error. Contributing doc has instruction on how to run it locally on your machine.

I'm recieving this error, need some help with this @phuhung273

[aws-cdk-automation]

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

[pahud]

Error: ERROR! Dependency @aws-cdk/integ-runner@^2.190.2 from @aws-cdk-testing/framework-integ not present in yarn.lock. Please run 'yarn install' and try again!
    at errorIfNotInYarnLock (/codebuild/output/src1157648621/src/actions-runner/_work/aws-cdk/aws-cdk/scripts/check-yarn-lock.js:45:13)
    at /codebuild/output/src1157648621/src/actions-runner/_work/aws-cdk/aws-cdk/scripts/check-yarn-lock.js:50:80
    at Array.forEach (<anonymous>)
    at /codebuild/output/src1157648621/src/actions-runner/_work/aws-cdk/aws-cdk/scripts/check-yarn-lock.js:50:45
    at Array.forEach (<anonymous>)
    at main (/codebuild/output/src1157648621/src/actions-runner/_work/aws-cdk/aws-cdk/scripts/check-yarn-lock.js:49:12)
Error: Process completed with exit code 1.

Hi @harryfrzz I think you'll need to run yarn install to update yarn.lock and make sure the conflict is resolved.

[pahud]

As this one got stale for a few days and obviously needs some troubleshooting, I decided to work on #36016 and hopefully get the 1.34 support ASAP.

[pahud]

close in favor of #36016

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.