[v2] Add profile and role sorting to sso configure#6205
[v2] Add profile and role sorting to sso configure#6205ryansonshine wants to merge 2 commits intoaws:v2from
sso configure#6205Conversation
This change adds sorting to profiles and roles when running `aws sso configure` listing them in ascending alphabetical order by default (case insensitive).
ryansonshine
changed the title
sso configure
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #6205 +/- ##
=======================================
Coverage 94.18% 94.18%
=======================================
Files 273 273
Lines 21678 21680 +2
=======================================
+ Hits 20417 20419 +2
Misses 1261 1261 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ryansonshine
changed the title
sso configuresso configure
kdaily
added
the
customization
kdaily
added
feature-request
|
@kdaily looking for any updates on when this will be merged |
kdaily
added
the
needs-review
|
Please merge this, it's soooo frustrating to look for the specific account when there are tens of them me the order changes every time... |
@kdaily is there a specific team that needs to review this? If so, can we ping them and get an update? Issue #6108 has 35 👍's and this PR hasn't seen an update for over 5 months, it's a bit discouraging for contributors to put in the time and effort to voluntarily implement functionality only for it to go ignored. |
|
@joguSD , is this something you're able to review? |
|
Any chance this feature graduates? It would be so helpful for my day to day as a heavy AWS user... |
stealthycoin
removed
pr:needs-review
|
Hi @ryansonshine thanks for the PR. Our team just put out a recent proposal in #6828 detailing improvements to the contribution process. We are working through open PRs and have determined this PR to be in the Implementation stage (described here). We are tracking this PR here on our project board and it can be set to to the review stage once new changes are ready to be reviewed. This will happen once we get through most of the open PRs and sort the open PRs against the criteria in our new contribution guide. |
|
Hi @stealthycoin, any updates on this PR please ? Thx |
|
Hello @stealthycoin 🆙 please Thanks a lot ! |
|
Hi again ! Can someone do the necessary to review and merge this Pull Request please ? Thanks |
|
Hello, this PR is opened since 2 years and no updates :-( Regards |
|
Any updates on this PR, please? |
12 participants
Issue #, if available:
Closes #6108
Description of changes:
This change adds sorting to profiles and roles when running
aws sso configurelisting them in ascending alphabetical order by default (case insensitive).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.