Skip to content

Conversation

@muhammad-othman
Copy link
Member

Description

Modified error response unmarshalling to directly update errorResponse object instead of using intermediate variables. For AWS Query compatible services, error codes are now extracted and set on the errorResponse object within the generate AWSQueryCompatibleBlock, this allowed us to remove conditional AWS Query compatible checks in JsonRPCExceptionUnmarshaller and CborExceptionUnmarshaller since the errorResponse already contains the proper code and type.
The manual changes were made in 07dfa93 the other commit only contains generated changes.
This PR is similar to #4253 for v3.

Motivation and Context

DOTNET-8439

Testing

  • Tested some SQS and CloudWatch operations manually and made sure they are throwing the proper exceptions.
  • DRY_RUN-85d01fdb-4448-4e40-83b9-c44a2b4b47c6

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@dscpinheiro dscpinheiro self-requested a review December 24, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants