Improve AWS Query compatible error handling in unmarshallers v4 #4257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modified error response unmarshalling to directly update errorResponse object instead of using intermediate variables. For AWS Query compatible services, error codes are now extracted and set on the errorResponse object within the generate AWSQueryCompatibleBlock, this allowed us to remove conditional AWS Query compatible checks in
JsonRPCExceptionUnmarshallerandCborExceptionUnmarshallersince theerrorResponsealready contains the proper code and type.The manual changes were made in 07dfa93 the other commit only contains generated changes.
This PR is similar to #4253 for v3.
Motivation and Context
DOTNET-8439Testing
DRY_RUN-85d01fdb-4448-4e40-83b9-c44a2b4b47c6Screenshots (if appropriate)
Types of changes
Checklist
License