-
Notifications
You must be signed in to change notification settings - Fork 873
[V4] Add missing SkipVersionCheck to TransactWriteConfig #4259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note but this class is getting out of hand, there's almost 5k lines... Before the test refactoring is done, I'll see if I can clean up this a little bit (for example, by moving the DynamoDBTable classes to their own files).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request addresses issue #4243 by adding the missing SkipVersionCheck property to the TransactWriteConfig class. Previously, customers had to use deprecated overloads that accept DynamoDBOperationConfig to skip version checks in transactional writes. This change brings TransactWriteConfig into alignment with other configuration classes like SaveConfig, DeleteConfig, and BatchWriteConfig, which already support this property.
Key Changes:
- Added
SkipVersionCheckproperty toTransactWriteConfigclass - Updated the property mapping in
ToDynamoDBOperationConfig()method - Improved error message clarity by removing reference to
DynamoDBContextConfig - Added comprehensive integration test to verify the fix
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/src/Services/DynamoDBv2/Custom/DataModel/TransactWriteConfig.cs | Added SkipVersionCheck property with documentation and integrated it into the config conversion method |
| sdk/src/Services/DynamoDBv2/Custom/DataModel/TransactWrite.cs | Updated error message to be more accurate now that SkipVersionCheck is available on TransactWriteConfig |
| sdk/test/Services/DynamoDBv2/UnitTests/Custom/DataModelOperationSpecificConfigTests.cs | Updated property count assertion from 5 to 6 to reflect the new property |
| sdk/test/Services/DynamoDBv2/IntegrationTests/DataModelTests.cs | Added integration test to verify SkipVersionCheck functionality works correctly with TransactWriteConfig |
| generator/.DevConfigs/fde42955-138d-44dc-8373-e98e836b33e3.json | Added dev config file with patch version bump and changelog entry |
ashishdhingra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fixes #4243
Description
The
TransactWriteConfigclass introduced in V4 for DynamoDB did not include theSkipVersionCheckoption, requiring customers to use the overloads that accept aDynamoDBOperationConfiginstead (which have been marked as deprecated).Testing
Dry-run:
DRY_RUN-89adcabb-d0d4-44a9-bdad-31823b3e6f9dTypes of changes
Checklist
License