Add integration tests workflow #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add integration-tests.yml workflow with OIDC authentication and pull_request_target - Support team member detection and safe-to-test label for external contributors - Remove #[ignore] annotations from all 6 integration tests - Add dynamic port allocation using atomic counter to prevent port conflicts - Add proper randomness to secret naming (thread ID + nanoseconds + random number) - Add fastrand dependency for random number generation - Update test-local.sh to remove --ignored flag and update comments - Enable both sequential (--test-threads=1) and parallel test execution
Use 'safe to test' (with spaces) to align with other AWS repositories
- COLLABORATOR: automatic test execution - Others: require 'safe to test' label for manual approval - Remove repo source checks - only author trust level matters
simonmarty
requested changes
Oct 16, 2025
simonmarty
requested changes
Oct 16, 2025
reyhankoyun
force-pushed
the
add-integration-tests-workflow
branch
from
03774c2 to
3a9a4f3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 14 14
Lines 2418 2418
Branches 2418 2418
=======================================
Hits 2218 2218
Misses 150 150
Partials 50 50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simonmarty
reviewed
Oct 16, 2025
simonmarty
requested changes
Oct 16, 2025
simonmarty
previously approved these changes
Oct 16, 2025
Signed-off-by: Simon Marty <simon.marty@protonmail.com>
simonmarty
previously approved these changes
Oct 16, 2025
ThirdEyeSqueegee
requested changes
Oct 16, 2025
- Add reopened trigger (part of default set) - Add ready_for_review trigger for draft PRs marked ready - Add Checkout step name for consistency
ThirdEyeSqueegee
approved these changes
Oct 17, 2025
simonmarty
approved these changes
Oct 17, 2025
lohdipak
reviewed
Oct 17, 2025
lohdipak
approved these changes
Oct 17, 2025
simonmarty
added a commit
to aws/secrets-store-csi-driver-provider-aws
that referenced
this pull request
Nov 3, 2025
*Issue #, if available:* *Description of changes:* Fork run: https://github.com/simonmarty/secrets-store-csi-driver-provider-aws/actions/runs/18887954508 (will try to keep this link up to date during review) Add initial integration test workflow. The workflow triggers on `pull_request_target` similar to aws/aws-secretsmanager-agent#136 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
#[ignore]annotations and enable all 6 integration tests to run in CIpull_request_targetwith team member detection andsafe-to-testlabel requirement for external contributorsTesting
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.