Skip to content

feat(cloudformation): enforce s3 upload for large templates and artif…#8711

Merged
branrin merged 2 commits intoaws:feature/toolkitOnlyfrom
Zee2413:force-s3-upload2
Apr 7, 2026
Merged

feat(cloudformation): enforce s3 upload for large templates and artif…#8711
branrin merged 2 commits intoaws:feature/toolkitOnlyfrom
Zee2413:force-s3-upload2

Conversation

@Zee2413
Copy link
Copy Markdown
Contributor

@Zee2413 Zee2413 commented Apr 3, 2026

…acts

Problem

  • user was not forced to upload large templates to s3

Solution

  • check template size and force user to upload to s3 whenever template is too large or contains local artifact

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Zee2413 Zee2413 requested a review from a team as a code owner April 3, 2026 20:38
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@chrisqm-dev
Copy link
Copy Markdown
Contributor

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.

    * Note: beta or "experiment" features that have active users _should_ announce fixes in the changelog.
    * If this is not a feature or fix, use an appropriate type from the [title guidelines](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#pull-request-title). For example, telemetry-only changes should use the `telemetry` type.
    

We should add a changelog for this

@Zee2413 Zee2413 force-pushed the force-s3-upload2 branch from 893f99b to da53081 Compare April 7, 2026 17:27
@Zee2413
Copy link
Copy Markdown
Contributor Author

Zee2413 commented Apr 7, 2026

Relies on aws-cloudformation/cloudformation-languageserver@91fab47 being released but this change is backwards compatible and gracefully degrades to previous behavior.

@branrin branrin merged commit 42bdd87 into aws:feature/toolkitOnly Apr 7, 2026
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants