Add functionality to configure TorchServe logging levels using the TS_LOG_LEVEL environment variable.#168
Open
lavaraja wants to merge 9 commits intoaws:masterfrom
Open
Add functionality to configure TorchServe logging levels using the TS_LOG_LEVEL environment variable.#168lavaraja wants to merge 9 commits intoaws:masterfrom
lavaraja wants to merge 9 commits intoaws:masterfrom
Conversation
- Added a new function 'configure_logging()' to dynamically set log levels - Utilize TS_LOGLEVEL environment variable to control logging verbosity - Support log levels: OFF, FATAL, ERROR, WARN, INFO, DEBUG, TRACE - Modify log4j2.xml file using sed command based on TS_LOGLEVEL - Handle potential errors during log configuration gracefully - Call configure_logging() before starting TorchServe - Aim to reduce excessive logging and associated CloudWatch costs - Maintain default logging if TS_LOGLEVEL is not set or invalid
Added missing import.
updating the log4j2 path.
using absolute path to prevent file not found errors.
Fix for aws#83
Author
|
Updated variable name from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: : #83
Description of changes:
In some cases, excessive logging is contributing to CloudWatch logging costs. This change allows users to control the logging verbosity, potentially reducing costs while maintaining the ability to increase verbosity for debugging when needed.
Changes :
OFF,FATAL,ERROR,WARN,INFO,DEBUG,TRACE. Re-mapped the TS_LOG_LEVEL values to corresponding integer values as follows.log4j2.xmlfile using sed command based on TS_LOG_LEVELTests:
Steps to test on Pytorch container :
docker build .docker tag <image_id> 763104351884.dkr.ecr.us-east-1.amazonaws.com/pytorch-inference:2.1-cpu-py310-extendedTS_LOG_LEVELas environment variable in the model class. Used this sample example for testing locally.pytorch_script_mode_local_model_inference.pyand use custom built container asimage_uripython pytorch_script_mode_local_model_inference.pyto start the container locally and run the inference.test_output_with_diff_loglevels.log
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.