feat(kiro): add Kiro configuration for code-review and pr-review-toolkit#76
Open
scottschreckengaust wants to merge 19 commits intomainfrom
Open
feat(kiro): add Kiro configuration for code-review and pr-review-toolkit#76scottschreckengaust wants to merge 19 commits intomainfrom
scottschreckengaust wants to merge 19 commits intomainfrom
Conversation
…plugins Translates the code-review@claude-plugins-official and pr-review-toolkit@claude-plugins-official Claude Code plugins into Kiro-native .kiro/ project configuration using steering files, skills, and the Agent Skills standard. Co-Authored-By: Claude <noreply@anthropic.com>
The project schema (skill-frontmatter.schema.json) and existing plugins only use name and description. Remove license and metadata fields to match repo conventions.
…kills Kiro skills don't dynamically load other skills by reference. Use the bundled reference docs which already contain the condensed instructions.
No MCP servers are needed for the review skills. An empty config adds noise without value.
The steering file code-review-standards.md is auto-included. Remove duplicated scoring scales from code-review, code-reviewer, and the review-pr code-reviewer reference to save context tokens.
Align code-review output template with the steering file convention which already uses 'guideline says' instead of 'CLAUDE.md says'.
scottschreckengaust
changed the title
Signed-off-by: Scott Schreckengaust <345885+scottschreckengaust@users.noreply.github.com>
Member
Author
Code reviewNo issues found. Checked for bugs and project guideline compliance. |
Member
Author
Comprehensive PR ReviewSummaryCompleted 8 review aspects on PR#76. All reviews passed with no issues found. Reviews Completed
Critical Issues0 found Important Issues0 found Suggestions0 found Strengths
Recommended Action✅ Ready to merge - No issues found across all review aspects. Automated review completed by Kiro code review skills |
Contributor
Consider: https://kiro.dev/docs/cli/chat/subagents/ and https://kiro.dev/docs/cli/custom-agents/creating/ |
Member
Author
Restructuring Plan: Skills → Custom Agents + SubagentsThe key insight from the Kiro docs is that the current PR uses only skills (SKILL.md files), but Kiro's custom agent system offers a much more powerful approach. The What changes and whyCurrent structure (skills only): Proposed structure (agents + skills + subagents): Specific changes
Files to delete
Files to keep (unchanged)
Key benefits
|
…ents - Convert code-review skill to custom agent with explicit shell tool access for gh CLI (replaces Claude Code-specific allowed-tools) - Convert review-pr orchestrator skill to custom agent using subagent pattern for parallel review execution - Keep 6 individual review skills (code-reviewer, code-simplifier, comment-analyzer, pr-test-analyzer, silent-failure-hunter, type-design-analyzer) as skills loaded via skill:// resources - Remove references/ directory (duplicated content eliminated by subagents loading skills directly) - Agent prompts stored in .kiro/agents/prompts/ via file:// URI Refs: https://kiro.dev/docs/cli/chat/subagents/ Refs: https://kiro.dev/docs/cli/custom-agents/creating/
- Add .kiro/steering/development-workflow.md (auto-loaded) with mise build commands, boundaries, and git worktree workflow from AGENTS.md - Add design-guidelines skill pointing to docs/DESIGN_GUIDELINES.md - Add development-guide skill pointing to docs/DEVELOPMENT_GUIDE.md - Add troubleshooting skill pointing to docs/TROUBLESHOOTING.md - Fix dprint formatting in review-pr prompt Skills use on-demand loading: metadata loaded at startup, full content loaded when the agent determines it is needed. The steering file is auto-included so agents always have build commands and boundaries.
…lows On-demand skill pointing to docs/MAINTAINERS_GUIDE.md with PR review criteria, merge rules, labels, and stale automation summary.
…nals Skills now contain only frontmatter (name + description for intent matching) and a pointer to the actual docs/*.md file. Eliminates content duplication and risk of drift.
- code-review: add shell to allowedTools (needed for gh CLI) - review-pr: add shell and subagent to allowedTools (needed for gh CLI and spawning code-review subagents)
…erences Replace stub 'Read docs/...' content with actionable workflow summaries. Add references/full-guide.md symlinks pointing to the original docs/ files to avoid content duplication while keeping the skill structure intact.
Replace bash-only ${LOG_LEVEL,,} with tr for /bin/sh compatibility.
code-review is a read-only agent that posts comments via gh CLI. It does not need write (file modification) or subagent capabilities.
…, reorder guideline sources
…nt checkov TRACE remap
…checkov LOG_LEVEL - code-reviewer: list .kiro/steering/ first in guideline source order - review-pr: clarify only code-review runs as subagent, other skills run inline using loaded resources - mise.toml: unset LOG_LEVEL entirely instead of only remapping TRACE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
code-review@claude-plugins-officialandpr-review-toolkit@claude-plugins-officialClaude Code plugins into Kiro-native.kiro/project configurationagentskills.io)Kiro Configuration Summary
Mapping: Claude Plugins → Kiro
code-reviewcommand.kiro/agents/code-review.json+prompts/code-review.mdreview-prcommand.kiro/agents/review-pr.json+prompts/review-pr.md.kiro/skills/{code-reviewer,code-simplifier,comment-analyzer,pr-test-analyzer,silent-failure-hunter,type-design-analyzer}/SKILL.md.kiro/steering/code-review-standards.mdStructure
Key Adaptations
descriptionfields against user intent, same pattern as Claude agent descriptions)allowed-tools→ Kiroallowed-toolsin frontmatter (experimental in Kiro)inclusion: autoso confidence scoring standards are loaded when doing review workreferences/via symlinks to existingdocs/filesAncillary Cleanup
The following changes are included alongside the Kiro configuration:
mise.toml: Fix checkov crash by unsettingLOG_LEVELbefore invocation (mise sets it toTRACE, which checkov does not recognize).github/CODEOWNERS: Add.kiro/ownership entry foragent-plugins-admins; addamazon-location-serviceplugin team entry; reformat alignment for consistencyAGENTS.md: Remove "Reference Documentation" section referencing deleted.claude/docs/directorydocs/DESIGN_GUIDELINES.md: Remove.claude/docs/references.markdownlint-cli2.yaml: Remove.claude/docs/**ignore (directory no longer exists)dprint.json: Remove**/.claude/docs/**exclude (directory no longer exists)plugins/amazon-location-service/.claude-plugin/plugin.json: Sort JSON keys alphabetically; change license fromMIT-0toApache-2.0to match repo LICENSEplugins/amazon-location-service/.mcp.json: Sort JSON keys alphabeticallyTest plan
/slash command listcode-review-standardssteering auto-loads when discussing code review/code-reviewskill on a sample PR/review-prskill with default (all aspects) and specific aspectssilent-failure-hunter) auto-trigger on relevant context🤖 Generated with Claude Code
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.