Open
Conversation
… service_worker_fix
… service_worker_fix
… service_worker_fix
… service_worker_fix
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The polyfills is a workaround to introduce node APIs such as buffer and process in all javascript environments. In our original design, we set it up through window by
window.Buffer = buffer.Buffer;.However,
windowonly exits in browser. In some of the javascript environments like service worker, the polypill would not work aswindowwould not exit there.Therefore, we change it to
self.selfgives us access to the global scope regardless of browser context. For example in the DOM,selfwould returnwindow, while in a service workerselfwill returnServiceWorkerGlobalScope.The fix should be able to bind the Buffer and process polyfills.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.