feat: Add code generator build plugin to service clients #2058
+34
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jbelkins
commented
Nov 16, 2025
| // Smithy plugins | ||
| static var SmithyCodeGenerator: Self { .plugin(name: "SmithyCodeGenerator", package: "smithy-swift") } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This file is just code-generated from the Package.base.txt above.
jbelkins
commented
Nov 16, 2025
| rm -rf Sources/Services/* | ||
| rm -rf Tests/Services/* | ||
| rm -rf SmokeTests/* | ||
| rm -rf Sources/Core/AWSIdentity/InternalClients/* |
Contributor
Author
There was a problem hiding this comment.
Remove the internal clients before development codegen & allow them to be regenerated.
jbelkins
commented
Nov 16, 2025
| extension Target.PluginUsage { | ||
| // Smithy plugins | ||
| static var SmithyCodeGenerator: Self { .plugin(name: "SmithyCodeGenerator", package: "smithy-swift") } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This extension is a convenience for use when installing the plugin into service clients.
jbelkins
commented
Nov 16, 2025
| dependencies: internalAWSSTSDependencies, | ||
| path: "Sources/Core/AWSSDKIdentity/InternalClients/InternalAWSSTS/Sources/InternalAWSSTS" | ||
| path: "Sources/Core/AWSSDKIdentity/InternalClients/InternalAWSSTS/Sources/InternalAWSSTS", | ||
| plugins: [.SmithyCodeGenerator] |
Contributor
Author
There was a problem hiding this comment.
Here & below, the code generator plugin is added to the 4 internal clients and to all AWS service targets.
jbelkins
commented
Nov 16, 2025
| .contentsOfDirectory(atPath: "../smithy-swift/Sources") | ||
| .sorted() | ||
| .filter { $0 != "libxml2" } // Ignore libxml module | ||
| .filter { $0 != "SmithyCodegenCLI" } // Ignore codegen component |
Contributor
Author
There was a problem hiding this comment.
Omits non-public codegen components from generated docs.
sichanyoo
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Companion PR smithy-lang/smithy-swift#999 creates a build tool plugin for native-Swift code generation.
This PR inserts the new code generator plugin into both internal and public service targets.
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.