Improve error message for missing annotation #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
It might be even better to just return empty data in this case, so that the annotation is optional. I ended up filling in a bogus filter value to get that behavior. |
Contributor
|
Hi @keegangroth thanks for the PR. I'm also wondering if we should just return empty data, since cost insights frontend just can't seem to handle the current behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
Improved mysterious log message when annotations were not provided for entities.
Description of changes
Add the entityRef to the error message
Description of how you validated changes
Modified a local copy, started backstage app and observed the log.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license