Replace bats embed with bats-core submodule #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Signed-off-by: Clarence "Sparr" Risher <clrnc@amazon.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bats was archived two years ago and bats-core is the active community-maintained fork. This PR is motivated by significantly increased functionality in the newer version, including
-fto filter and run specific tests, options to control test output for debugging, additional warnings (which have identified one already-broken test which I'll fix in a PR and link shortly), and much more.Description of changes:
Remove
test/bats/*and add a new submodule that checks out https://github.com/bats-core/bats-core totest/bats-core.Add Makefile target that checks out the submodule if necessary for
make testRelevant doc and comment updates.
Also update test Github workflow to allow manual dispatch.
Also minor formatting updates to CONTRIBUTING.md.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.