feat: PLG-130 - add WP Consent API categories integration #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix initialization bug (axeptioSettings → axeptioWpConsentCategories) - Add 5 WP Consent API categories as virtual vendors - Update consent directly without Google Consent Mode dependency - Refactor categories data to single source of truth - Add WordPress favicon for consent categories
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 12 files
Prompt for AI agents (all 1 issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="assets/js/frontend/axeptio.js">
<violation number="1" location="assets/js/frontend/axeptio.js:12">
P2: The `wp_consent_change` CustomEvent is no longer dispatched after consent is updated. This event is part of the WP Consent API specification and other consent-aware WordPress plugins may depend on it to react to consent changes. Consider dispatching the event after setting consents.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
| if ( typeof wp_set_consent === 'function' ) { | ||
| window.axeptioWpConsentCategories.forEach( ( category ) => { | ||
| wp_set_consent( category, 'deny' ); | ||
| } ); |
There was a problem hiding this comment.
P2: The wp_consent_change CustomEvent is no longer dispatched after consent is updated. This event is part of the WP Consent API specification and other consent-aware WordPress plugins may depend on it to react to consent changes. Consider dispatching the event after setting consents.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At assets/js/frontend/axeptio.js, line 12:
<comment>The `wp_consent_change` CustomEvent is no longer dispatched after consent is updated. This event is part of the WP Consent API specification and other consent-aware WordPress plugins may depend on it to react to consent changes. Consider dispatching the event after setting consents.</comment>
<file context>
@@ -1,18 +1,17 @@
+if ( typeof wp_set_consent === 'function' ) {
+ window.axeptioWpConsentCategories.forEach( ( category ) => {
+ wp_set_consent( category, 'deny' );
+ } );
}
-let consentTypeEvent = new CustomEvent('wp_consent_type_defined');
</file context>
pleberre
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Integrates WP Consent API categories into the Axeptio widget and syncs consent directly via wp_set_consent. Removes the Google Consent Mode dependency and sets categories to deny on init.
New Features
Bug Fixes
Written for commit ff2e9b0. Summary will update automatically on new commits.