Skip to content

feat: github api base url #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunfkny wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: github api base url #280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions axoupdater/src/release/github.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ use url::Url;

fn github_api(app_name: &str) -> AxoupdateResult<String> {
let formatted_app_name = app_name_to_env_var(app_name);

let github_api_env_var = format!("{}_INSTALLER_GITHUB_API_BASE_URL", formatted_app_name);
if let Ok(value) = env::var(&github_api_env_var) {
let parsed = Url::parse(&value)?;
return Ok(parsed.to_string());
}

let ghe_env_var = format!("{}_INSTALLER_GHE_BASE_URL", formatted_app_name);
let github_env_var = format!("{}_INSTALLER_GITHUB_BASE_URL", formatted_app_name);

Expand Down Expand Up @@ -425,6 +432,47 @@ mod test {
assert_eq!(result, "https://127.0.0.1/api/v3");
}

#[test]
#[serial] // modifying the global state environment variables
fn test_github_api_base_url() {
env::set_var(
"DIST_INSTALLER_GITHUB_API_BASE_URL",
"https://magic.com/api.github.com",
);
let result = github_api("dist").unwrap();
env::remove_var("DIST_INSTALLER_GITHUB_API_BASE_URL");

assert_eq!(result, "https://magic.com/api.github.com");
}

#[test]
#[serial] // modifying the global state environment variables
fn test_github_api_base_url_override_others() {
env::set_var(
"DIST_INSTALLER_GITHUB_API_BASE_URL",
"https://magic.com/api.github.com",
);
env::set_var("DIST_INSTALLER_GITHUB_BASE_URL", "https://github.com");
env::set_var("DIST_INSTALLER_GHE_BASE_URL", "https://ghe.com");

let result = github_api("dist").unwrap();

env::remove_var("DIST_INSTALLER_GITHUB_API_BASE_URL");
env::remove_var("DIST_INSTALLER_GITHUB_BASE_URL");
env::remove_var("DIST_INSTALLER_GHE_BASE_URL");

assert_eq!(result, "https://magic.com/api.github.com");
}

#[test]
#[serial] // modifying the global state environment variables
fn test_github_api_base_url_bad_value() {
env::set_var("DIST_INSTALLER_GITHUB_API_BASE_URL", "this is not a url");
let result = github_api("dist");
env::remove_var("DIST_INSTALLER_GITHUB_API_BASE_URL");
assert!(result.is_err());
}

#[tokio::test]
#[serial] // modifying the global state environment variables
async fn test_get_latest_github_release_custom_endpoint() {
Expand Down