Draft
Conversation
adityalj
commented
Jul 23, 2025
| reject(state, printRejectionReason, "MIWaveTile0(%u) should be multiple of VectorWidthB(%u)" % (state["MIWaveTile"][1], state["VectorWidthB"])) | ||
| return | ||
|
|
||
| if ((state["DepthU"] ==state["MatrixInstK"] )and state["PrefetchGlobalRead"]): |
Author
There was a problem hiding this comment.
Add Wavesizes not supported here
Author
There was a problem hiding this comment.
Rename D_U_iseqMI_K as DuEqMIK
| mfmaiter2 = math.ceil(kernel["MIWaveTile"][0]/2) * math.floor(kernel["MIWaveTile"][1]/2) | ||
| writer.states.syncPlrMfmaIndex = (mfmaiter0 + mfmaiter1 + mfmaiter2) | ||
| if ( kernel["UseF32XEmulation"]) : | ||
| writer.states.syncPlrMfmaIndex = writer.states.syncPlrMfmaIndex *3 # TF32 |
| if kernel["1LDSBuffer"] or kernel["DirectToLds"]: | ||
| writer.states.sync1LdsMfmaIndex = max(writer.states.lwStartMfmaIndex - 1, 0) | ||
| startIter = writer.states.lwStartMfmaIndex//numMfmaPerIter | ||
| if kernel["D_U_iseqMI_K"]: |
| else: | ||
| for vIdx in range(0, numVectorsPerTile): | ||
| for eIdx in range(0, numReadsPerVector): | ||
| eIdxCnt = numReadsPerVector |
Author
There was a problem hiding this comment.
Generate an example to demonstrate the issue
| isBarrier = kernel["LoopIters"] - self.states.numItersPLR | ||
| writeItems = list(localWriteCode.items()) | ||
| macIterItems = macIterCode.flatitems() | ||
| numMfmaPerIter = len(macIterItems) |
Author
There was a problem hiding this comment.
print subiter instead pf iter at appropriate place
| itemCounter = 0 | ||
| for i in range(numMfmaPerIter): | ||
| mfmaIndex = iteration * numMfmaPerIter + i | ||
| kernel["mfmaIndex"] = kernel["mfmaIndex"] + 1 |
| iterCode.add(SSetPrior(prior=3, comment="store optimization")) | ||
| if (mfmaIndex >= self.states.lwStartMfmaIndex): | ||
| numLoops, itemCounter = calculateRangeAndUpdateCounter(itemCounter, localWriteCodeCounts, self.states.numLocalWriteModPerMfma) | ||
| if kernel["D_U_iseqMI_K"]: |
| self.makeSchedule(kernel, tensorParametersA, tensorParametersB, localWriteEndIter, skipGlobalReadInc=False, lastLoop=NLLlast, isNGLL=isNGLL) | ||
| module.add(self.codes.unrollLoopHeader) | ||
|
|
||
| if kernel["D_U_iseqMI_K"]: |
adityalj
force-pushed
the
adijoshi_plr_tf32
branch
from
580587b to
a3fd9d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.