Open
Conversation
vbrazo
force-pushed
the
master
branch
17 times, most recently
from
a359def to
a5d7731
Compare
vbrazo
force-pushed
the
master
branch
4 times, most recently
from
6cd6373 to
a8229de
Compare
vbrazo
force-pushed
the
master
branch
5 times, most recently
from
cac2683 to
5114410
Compare
* Reformat YAML file * Improve stack matcher * Remove comment
* Removed ruby version checks in test_faker_library_in_leap_year * Removed ruby version check from test_faker_id_number.rb * Updated targeted ruby version for Rubocop * updated required ruby version in faker.gemspec * fixed the test that check for the error raised in test_birthday_in_leap_year and test_invalid_south_african_id_number * removed versions of ruby older than 2.7 from test matrix * removed duplicate code from test_brazilian_citizen_number and autocorrected offenses with rubocop * autocorrected using rubocop
Updates the requirements on [minitest](https://github.com/seattlerb/minitest) to permit the latest version. - [Release notes](https://github.com/seattlerb/minitest/releases) - [Changelog](https://github.com/minitest/minitest/blob/master/History.rdoc) - [Commits](minitest/minitest@v5.15.0...v5.16.3) --- updated-dependencies: - dependency-name: minitest dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Note that `Gemspec/RequireMFA` is enabled. Please refer to the article below for RubyGems MFA status. https://blog.rubygems.org/2022/08/15/requiring-mfa-on-popular-gems.html
This PR sets `true` to `rubygems_mfa_required` gemspec metadata. It's important for security. Please note that MFA will be required upon release. https://guides.rubygems.org/setting-up-multifactor-authentication/
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.28.2...v1.35.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Fix `fma_brotherhood` usage example
Bump faker to 2.23.0
Set true to `rubygems_mfa_required` gemspec metadata
Updates the requirements on [rubocop](https://github.com/rubocop/rubocop) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.35.1...v1.36.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Upgrade SimpleCov version to latest version * Remove comment * No need to explicitely set SimpleCovFormatter * Add CI=1 CC_TEST_REPORTER_ID=1 to tests * this is not right * Changing simplecov formatter
Follow up #2556 (comment)
* Fix Faker::Vehicle.vin - Dashes aren't permitted in VINs. - This is a partial revert and fix of d113aab - See d113aab#r83976559 * Improved Faker::Vehicle.vin validity test
Updates the requirements on [rubocop-minitest](https://github.com/rubocop/rubocop-minitest) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop-minitest/releases) - [Changelog](https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-minitest@v0.22.0...v0.22.1) --- updated-dependencies: - dependency-name: rubocop-minitest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The version of the dependency i18n has to be at least 1.8.11, so this `require` can be safely removed.
* Remove unneeded require in lib/faker.rb The version of the dependency i18n has to be at least 1.8.11, so this `require` can be safely removed. * This comment is not relevant anymore Co-authored-by: Dany Marcoux <dmarcoux@posteo.de>
* french traduction of positive adjectives * test added for french positive adjectives * french traduction of negative adjectives * test added for french negative adjectives * Add fr translation of ancients * Add tests for fr translation of ancients
* Add ability to override hsl_color lightness So we can generate lighter and darker colors as requested in the issue: #2464. Next step is to convert a light/dark hsl to hex. * Use hsl_color and hsl_to_hex to generate hex_color So we can easily specify when we want light or dark colors, since hsl values have a very intuitive way to specify light and dark colors. See: #2464 * Add ability to specify light or dark hex color New param allows user to pass in :light for light hex color and :dark for dark hex colors. Additional specs confirm that this works. See: #2464 * Update version to next As per: https://github.com/faker-ruby/faker/blob/master/CONTRIBUTING.md#documentation * Fix rubocop linting issue * Allow specific hue and saturation values for hsl_color Adding specs to confirm this works, and also prevents specifying invalid hsl colors. @see #2566 (comment) * Add LIGHTNESS_LOOKUP constant @see #2566 (comment) * Introduct hsl_hash to hex_color So it cash be used to pass values (such as hue and saturation) to hsl_color. See: #2566 (comment) * Rename lightness to args To make it more general. @see #2566 (comment) * Allow hue, saturation or lightness for hex colors So clients are able to generate very specific colors when needed. See: #2566 (comment) * Fix documentation typo
Updates the requirements on [rubocop-minitest](https://github.com/rubocop/rubocop-minitest) to permit the latest version. - [Release notes](https://github.com/rubocop/rubocop-minitest/releases) - [Changelog](https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-minitest@v0.22.1...v0.22.2) --- updated-dependencies: - dependency-name: rubocop-minitest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.