Skip to content

Improve feature set storage method, fix board definitions and other bugs #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Improve feature set storage method, fix board definitions and other bugs #6

wants to merge 8 commits into from

Conversation

@DeanBilotti
Copy link

@DeanBilotti DeanBilotti commented Jul 5, 2017 •
edited
Loading

These fixes include:

  • using bitwise operations to store board feature sets
  • fix for incorrect NUM_FEATURES constant (i.e. NUM_FEATURES is removed)
  • fix ATmega2560 compilation error
  • removal of duplicate (and incorrect) constant definitions from ArduinoBoardManager constructor
  • usage of board defines rather than hard coded literals
  • add header guard to avoid multiple #includes
  • separate out ATmega1280 and ATmega2560 to correct CPU_NAME

jpoppe and others added 3 commits August 27, 2016 16:14
@jpoppe
__AVR_Atmega32U4__ -> __AVR_ATmega32U4__
575e938 
Fixed Leonardo & co board detection.
@DeanBilotti
Use bitwise operators to store Arduino feature sets (fixes feature se…
132edf8 
…t bug where NUM_FEATURES set to 1 instead of 5)

Fix ATmega2560 compilation error (was in same #define as ATmega1280)

Remove duplicate constant definitions from ArduinoBoardManager constructor (the last 2 were incorrect anyway)
@DeanBilotti
Use board model defines rather than hard coded literals.
8e71597
@DeanBilotti DeanBilotti mentioned this pull request Jul 5, 2017
Open
@DeanBilotti DeanBilotti changed the title Improve feature set storage method and fix bugs with board definitions Improve feature set storage method, fix board definitions and other bugs Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DeanBilotti @jpoppe