-
Notifications
You must be signed in to change notification settings - Fork 0
update wallet integrations page #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughSe añadió una nueva guía de docs para integrar el Bando Widget con wallets de terceros (incl. World App via MiniKit) y se actualizó el índice (SUMMARY.md) para enlazarla bajo la sección de Spending Widget. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Dev App
participant BW as Bando Widget
participant TP as TransactionProvider<br/>(World MiniKit)
participant WA as Wallet App
participant L1 as Chain
Dev->>BW: Initialize BandoWidget({ transactionProvider: MiniKit, ...config })
BW->>TP: Request wallet auth
TP->>WA: Open Mini App auth/consent
WA-->>TP: Auth token / session
TP-->>BW: Auth success
Note over BW,TP: Ready to send tx usando MiniKit
BW->>TP: Create/submit transaction
TP->>WA: Prompt user to sign
WA-->>TP: Signed tx / approval
TP->>L1: Broadcast transaction
L1-->>TP: Tx receipt / status
TP-->>BW: Result
BW-->>Dev: Render status (success/error)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (5)
SUMMARY.md (1)
26-29: Hyphenate y reordena el TOC pa’ que no se mezcle con los subitems de Framework.“Third Party” → “Third‑party”, y deja el título en plural para empatar con la página (“Integrations”). También mueve la entrada debajo de Svelte para mantener juntitos los children de “Framework Integration”.
* [Framework Integration](widget/framework-integration/README.md) -* [Third Party Wallets Integration](widget/wallets-integration.md) * [Next.js](widget/framework-integration/nextjs.md) * [Svelte](widget/framework-integration/svelte.md) +* [Third‑party Wallet Integrations](widget/wallets-integration.md)widget/wallets-integration.md (4)
5-5: Consistencia de título: usa “Third‑party”.Hyphen pa’ gramática y pa’ cuadrar con el TOC sugerido.
-# Third Party Wallet Integrations +# Third‑party Wallet Integrations
10-16: Ajusta wording pa’ no confundir: dices “one extra step” pero listas varios.Mejor di “a few extra steps” o sé explícito que es “MiniKit setup + pasar el provider”.
-If you want to integrate it inside **World App**, you’ll just need one extra setup step. +If you want to integrate it inside **World App**, you’ll need a few extra setup steps (MiniKit setup + passing the provider).
31-42: Snippet: defineintegratory muestra imports pa’ que el copy/paste jale al tiro.Ahorita
integratoryWidgetConfigno están definidos/importados en el ejemplo. Esto baja la DX para la raza que copia el snippet.```typescript -import { MiniKit } from "@worldcoin/minikit-js"; +import { MiniKit } from "@worldcoin/minikit-js"; +// import { BandoWidget, type WidgetConfig } from "@bandohq/widget" // <-- ajusta el import real + +const integrator = "YOUR_INTEGRATOR_ID"; // <-- reemplaza con tu integrator export const Widget = () => { const config = { buildUrl: true, transactionProvider: MiniKit, - } as Partial<WidgetConfig>; + } as Partial<WidgetConfig>; // see widget/configure.md for config options
10-15: Añade nota de compatibilidad “out of the box”.Dices que Farcaster/Binance/Opera MiniPay vienen “by default”. Agrega una línea con versión mínima o limitaciones (p.ej., in-app browser, EIP-1193 bridge), para que la banda no se saque de onda si un entorno no cumple.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
SUMMARY.md(1 hunks)widget/wallets-integration.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
widget/wallets-integration.md
[grammar] ~12-~12: There might be a mistake here.
Context: ...t is ready to run inside: - Farcaster - Binance - Opera MiniPay If you wa...
(QB_NEW_EN)
[grammar] ~13-~13: There might be a mistake here.
Context: ...run inside: - Farcaster - Binance - Opera MiniPay If you want to integrat...
(QB_NEW_EN)
SUMMARY.md
[grammar] ~26-~26: There might be a mistake here.
Context: ...E.md) * Third Party Wallets Integration * [Next.js](widget/framework-integration/ne...
(QB_NEW_EN)
🔇 Additional comments (3)
SUMMARY.md (1)
26-26: Buen add, compa.El link apunta al path correcto y cae en la nueva guía.
widget/wallets-integration.md (2)
1-42: En general, chido el doc, homie.Claro y conciso; buen onboarding para wallets de terceros.
35-38: Órale, confirma el tipo detransactionProviderNo estamos seguros si el widget de Bando en @worldcoin/minikit-js (v. agosto 2025) espera:
- la exportación estática
MiniKit(namespace), o- una instancia inicializada (
new MiniKit(...)).Además, valida que el objeto que pases implemente la interfaz requerida, por ejemplo:
signTransaction(txParams): Promise<string>sendTransaction(signedTx): Promise<TransactionReceipt>- (otros métodos que el SDK documente, e.g.,
getBalance,estimateGas, etc.)Puntos a checar:
- widget/wallets-integration.md (líneas 35–38): ajusta el snippet para usar la forma correcta.
- Revisa la docs o el código fuente de @worldcoin/minikit-js para la firma exacta de los métodos.
No queremos romper el flujo en World App, así que mejor valida antes de mergear.
Pull Request Overview
Guide to integrate the widget on Dapps that will be used inside third party wallets as mini apps
Summary by CodeRabbit