feat(highlight): warn when hunks exceed max_lines#184
Merged
barrettruth merged 3 commits intomainfrom Mar 10, 2026
Merged
Conversation
barrettruth
force-pushed
the
feat/warn-max-lines
branch
2 times, most recently
from
64335a9 to
a72fa29
Compare
Problem: when a hunk's highlighted lines exceed `max_lines`, syntax highlighting is silently skipped. Users have no indication why parts of their diff lack highlighting. Solution: add `highlights.warn_max_lines` (default `true`) that emits a `vim.notify` warning with the hunk index and line count vs threshold. Also change `max_lines` to count only highlighted (`+`/`-`) lines rather than total body lines including context.
barrettruth
force-pushed
the
feat/warn-max-lines
branch
from
a72fa29 to
6e6f7e9
Compare
barrettruth
force-pushed
the
feat/warn-max-lines
branch
from
30c450f to
5015a5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a hunk's highlighted lines exceed
max_lines, syntax highlighting is silently skipped. Users have no indication why parts of their diff lack highlighting.Solution
Add
highlights.warn_max_lines(defaulttrue) that emits avim.notifywarning with the hunk index and line count vs threshold. Also changemax_linesto count only highlighted (+/-) lines rather than total body lines including context.